-
Notifications
You must be signed in to change notification settings - Fork 234
feat(W-19894449): add Sentry error reporting #3413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6430a05 to
287da7c
Compare
287da7c to
e6fc537
Compare
michaelmalave
requested changes
Nov 26, 2025
Contributor
michaelmalave
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good and accomplish the goal. left a comment before approval.
203d4fd to
714b846
Compare
michaelmalave
approved these changes
Dec 2, 2025
Contributor
michaelmalave
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! Nice implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Sentry error reporting to the CLI. Also adds scrubbing logic to ensure we are not sending PII or other privileged information to Sentry.
GUS work item: W-19894449
Testing
yarn && yarn build. Then runIS_DEV_ENVIRONMENT="true" ./bin/run apps:info -a <non-existent-app>. It may take a little time, but you should see the error show up in Sentry.