Add support for heroku-24 #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing due to |
joshwlewis
force-pushed
the
add-heroku-24
branch
from
f5b988f to
216771b
Compare
edmorley
approved these changes
Apr 23, 2024
edmorley
reviewed
May 2, 2024
| @@ -15,9 +15,10 @@ jobs: | |||
| runs-on: ubuntu-22.04 | |||
| strategy: | |||
| matrix: | |||
| stack-version: ["20", "22"] | |||
| stack-version: ["20", "22", "24"] | |||
There was a problem hiding this comment.
I've added the new Heroku-24 integration test job to the branch protection required checks list:
https://github.com/heroku/heroku-buildpack-go/settings/branch_protection_rules/424628
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds heroku-24 to the test matrix and enables heroku-24 support in this buildpack.