-
Notifications
You must be signed in to change notification settings - Fork 82
feat: add support for providing volume at the server creation time #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add support for providing volume at the server creation time #1116
Conversation
|
@jooola please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the new field to our documentation and add an end-to-end test for this field.
internal/server/resource.go
Outdated
| Elem: &schema.Schema{ | ||
| Type: schema.TypeString, | ||
| }, | ||
| ForceNew: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why this forces a new resource? It is possible to attach or detach volumes when the server already exists.
If this is because some of the usecases would benefit from this, ie. provisioning with cloud-init that needs to re-run if the volumes change, then this should be in the hands of the user, and not forced by the provider. There is an open TF issue for this: hashicorp/terraform#27456 Not sure if its possible to reference the resources own fields in the existing lifecycle.replace_triggered_by field.
|
@apricote thank you for feedback |
|
This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs. |
|
Sorry, we haven't had time to give a proper review. Reopening the PR to make sure we come back to it. |
This closes #502 and adds ability to provide ID of volumes at the time of server creation.