Add types #93
Open
Add types #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.0.0-rc.1
docs: fix doc style
docs: update docs
build: update package.json
docs: fix spelling mistake
docs: update doc
docs: update docs
build: release 1.0.0
update to version 1.1.0
docs: fix internal links in docs
docs: update docs
[1.1.1] Handle invalid parameter when initializing kuroshiro
Update to version 1.1.2
docs: update CONTRIBUTING.md
docs: update README
docs: update docs
* upgrade to babel 7 * attempt to fix errors occurring when converting っ to romaji (hexenq#61) * fix: wrong regex pattern fixed * build: bump deps * build(npm): add husky and lint-staged for pre-commit check * Esperanto docs (hexenq#71) * Update docs * add ready to use code in readme (hexenq#77) * build: bump deps Co-authored-by: Omar Diab <[email protected]> Co-authored-by: erdOne <[email protected]> Co-authored-by: bbible3 <[email protected]> Co-authored-by: Richard Osmar Leon Ingaruca <[email protected]>
|
This is great PR, but it seems the repository owner has been inactive for a while. Can this PR be opened to DefinitelyTyped instead? |
dathmart
approved these changes
Jan 16, 2024
| convert( | ||
| str: string, | ||
| options?: { | ||
| to?: string; |
There was a problem hiding this comment.
Suggested change
| to?: string; | |
| to?: 'hiragana' | 'katakana' | 'romaji'; |
Comment on lines
+10
to
+11
| mode?: string; | ||
| romajiSystem?: string; |
There was a problem hiding this comment.
Suggested change
| mode?: string; | |
| romajiSystem?: string; | |
| mode?: 'normal' | 'spaced' | 'okurigana' | 'furigana'; | |
| romajiSystem?: 'nippon' | 'passport' | 'hepburn'; |
|
when this PR will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating nice library.
I'm trying to use this library for my TypeScript project, but it needs declaration (.d.ts) file.
I saw below issue, but nobody has dealt with it, so I added.
#48
Also, please refer to this pull request. hexenq/kuroshiro-analyzer-kuromoji#7
If "kuroshiro" user uses "kuroshiro-analyzer-kuromoji", needs types as well.
Thank you.