Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle special Axios keywords when merging headers #1470

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Dec 19, 2024

Closes #1428

Copy link

stackblitz bot commented Dec 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 458ef50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hey-api/client-axios Patch
@example/openapi-ts-axios Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 6:39pm

@mrlubos mrlubos marked this pull request as ready for review December 19, 2024 18:38
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.31%. Comparing base (680e55f) to head (458ef50).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1470   +/-   ##
=======================================
  Coverage   63.31%   63.31%           
=======================================
  Files         143      143           
  Lines       22332    22332           
  Branches     1848     1848           
=======================================
  Hits        14139    14139           
  Misses       8187     8187           
  Partials        6        6           
Flag Coverage Δ
unittests 63.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@hey-api/client-axios@1470
npm i https://pkg.pr.new/@hey-api/openapi-ts@1470
npm i https://pkg.pr.new/@hey-api/client-fetch@1470

commit: 458ef50

@mrlubos mrlubos merged commit 670e537 into main Dec 19, 2024
17 checks passed
@mrlubos mrlubos deleted the fix/axios-merge-headers branch December 19, 2024 18:47
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting per method headers doesn't work
1 participant