Commit 95140e8
committed
docs(skills): fix what an eval of the audio preset docs found
Ran three realistic mixing tasks against the skill and against its state
before the preset docs landed, six runs in all, and audited every claim in
`presets.md` against the shipped catalogue.
Four things came back.
**Nodes need a `label`, and the skill never said so.** Zero of six runs
wrote one — including the run that otherwise nailed the task, placing the
exact shipped Tame Boominess and Reduce Boxiness settings. The rack shows
that chain as two identical `peaking` rows, which is the precise problem
the named jobs exist to dissolve. The doc taught the numbers and lost the
naming, which was the point. `label` now appears in `attributes.md` with
the reason, and the jobs section shows a labelled node.
**Single-quoted attributes are invisible to `carve.mjs`.** Three of six
runs wrote `data-fx-chain='{...}'`. The browser reads through
`getAttribute` and does not care; the script finds attributes with a
`name="..."` regex, so the carve sees no existing chain and overwrites
work it cannot find. The convention was never written down.
**"18 presets" — 19 ship.** The list was complete; only the numeral was
wrong. Dropped rather than corrected, since nothing keeps it honest.
**Every job also ships inside a preset at identical settings**, so
`voice-clean` plus a Reduce Mud job cuts 250 Hz twice. The doc listed both
vocabularies without connecting them.
Also: "Not covered" said what not to do without saying what to do, and it
cost real behaviour — asked to add a de-esser, the run with the doc changed
nothing while the run without it shipped a narrow 7 kHz cut with the
trade-off stated. The section now names the honest fallback per gap and
says to apply it.
Verified clean: the five job frequencies, all five profile curves and the
parameters each derives, the level-matching claim, append-and-replace
semantics, the leveller's 80th percentile, `presetAmount` and
`fx.preset.<id>`.1 parent fd0eb76 commit 95140e8
3 files changed
Lines changed: 44 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
22 | 29 | | |
23 | 30 | | |
24 | 31 | | |
| |||
28 | 35 | | |
29 | 36 | | |
30 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
31 | 43 | | |
32 | 44 | | |
33 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
138 | 152 | | |
139 | 153 | | |
140 | 154 | | |
| |||
184 | 198 | | |
185 | 199 | | |
186 | 200 | | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
193 | 214 | | |
194 | | - | |
| 215 | + | |
| 216 | + | |
0 commit comments