test(core): cover late nested video snapshots - #2869
Closed
miguel-heygen wants to merge 1 commit into
Closed
Conversation
miguel-heygen
force-pushed
the
fix/apps-982-nested-local-video-snapshot
branch
from
July 29, 2026 16:31
177ac07 to
16db457
Compare
Collaborator
Author
|
Closing as redundant after root-cause triage. The production fix already merged in #2859, and current main already has generalized coverage for later template-mounted scene-local video visibility plus arbitrary-depth absolute media-start resolution. This PR adds the same invariant again with different timestamps ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
A snapshot could hide a later nested video by interpreting its authored start as root-global instead of scene-local. Current main already contains the canonical runtime timing fix; this PR locks the distinct late-host timing shape as regression coverage without adding overlapping production logic.
How
Exercise the runtime visibility resolver with a nested template host and a local-time video, then assert the resolved absolute start and visibility at the affected global timestamp.
Test plan
visible, receivedhiddenat global 20s.packages/core:bunx vitest run src/runtime/init.test.ts— 69 passed.check --snapshots --at 3.4,20 --jsonpassed runtime, layout, and lint checks.