Skip to content

fix(skills): require user confirmation before skill updates - #3295

Merged
jrusso1020 merged 1 commit into
heygen-com:mainfrom
santhiprakash:fix/skill-update-user-confirmation
Aug 21, 2026
Merged

fix(skills): require user confirmation before skill updates#3295
jrusso1020 merged 1 commit into
heygen-com:mainfrom
santhiprakash:fix/skill-update-user-confirmation

Conversation

@santhiprakash

Copy link
Copy Markdown
Contributor

What

Replace the "run silently, don't ask" skill-freshness directive with explicit user-confirmation guidance in ten workflow SKILL.md files, and regenerate skills-manifest.json.

Why

Fixes the trust-model issue in #2613: published skills were instructing agents to run npx hyperframes skills update without surfacing it to the user. skills/general-video/SKILL.md already used safer wording; this aligns the remaining workflow skills.

How

One-line wording change per affected skill:

  • Before: run silently, don't ask
  • After: confirm with the user before running

No CLI or runtime behavior changes.

Test plan

  • bun packages/cli/scripts/gen-skills-manifest.ts --check — manifest in sync
  • rg "run silently, don't ask" skills -g SKILL.md — zero matches
  • rg "confirm with the user before running" skills -g SKILL.md — 10 matches (workflow skills)
  • CI: Skills manifest + docs checks

Notes

Fixes #2613 (silent self-update portion only; shell-injection and SRI items remain open in the issue).

@santhiprakash
santhiprakash force-pushed the fix/skill-update-user-confirmation branch from debec29 to f23fbb3 Compare August 18, 2026 07:06
@jrusso1020

Copy link
Copy Markdown
Collaborator

@santhiprakash can you sign the commits please

@santhiprakash
santhiprakash force-pushed the fix/skill-update-user-confirmation branch from f23fbb3 to 66c9fe4 Compare August 19, 2026 17:41
@santhiprakash

Copy link
Copy Markdown
Contributor Author

Done — commits are now signed. You should see the Verified badge on the latest commit.

@santhiprakash
santhiprakash force-pushed the fix/skill-update-user-confirmation branch from 66c9fe4 to 5468af7 Compare August 20, 2026 14:31
@santhiprakash

Copy link
Copy Markdown
Contributor Author

Rebased onto current main (d09145fa) to clear the merge conflict. The only conflict was in the generated skills-manifest.json, resolved by re-running the canonical generator (bun run --cwd packages/cli gen:skills-manifest), not a hand merge. The commit is re-signed — Verified badge intact.

Verified on the new head 5468af7:

  • gen:skills-manifest --check — in sync (20 skills)
  • lint:skills — 32 skill files, no issues
  • check:skill-mirror — 24 files match byte-for-byte

@santhiprakash
santhiprakash force-pushed the fix/skill-update-user-confirmation branch from 5468af7 to aa2bbdd Compare August 20, 2026 23:15
Replace "run silently, don't ask" with explicit confirmation guidance
in ten workflow SKILL.md files so agents do not auto-run npx updates
without the user. Regenerate skills-manifest.json.

Refs heygen-com#2613
@santhiprakash
santhiprakash force-pushed the fix/skill-update-user-confirmation branch from aa2bbdd to fd21f15 Compare August 21, 2026 03:06
@santhiprakash

Copy link
Copy Markdown
Contributor Author

@jrusso1020 done — commits are now signed and the manifest check is green.

@jrusso1020
jrusso1020 merged commit efc2e19 into heygen-com:main Aug 21, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skills instruct agents to silently self-update via npx with no user confirmation; one script has an unreachable shell-injection shape

2 participants