Skip to content

fix(studio): put the timeline's portaled surfaces on the tier the other portals use #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vanceingalls merged 3 commits into from
Aug 22, 2026
Merged

fix(studio): put the timeline's portaled surfaces on the tier the other portals use #3414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f904ebf
fix(studio): put the timeline's portaled surfaces on the tier the oth…
vanceingalls Aug 22, 2026
4fa063d
fix(studio): move the remaining body-portaled context menus to the sa…
vanceingalls Aug 22, 2026
836922a
fix(studio): correct the interval in the popover in-bounds test comment
vanceingalls Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/studio/src/components/editor/CanvasContextMenu.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ describe("CanvasContextMenu — handler gating", () => {

// No menu opened at all — no buttons, no dead-end items, no DOM mutation.
expect(menuButtons()).toHaveLength(0);
expect(document.body.querySelector(".fixed.z-50")).toBeNull();
expect(document.body.querySelector(".fixed.z-\\[200\\]")).toBeNull();
expect(el.style.zIndex).toBe("3");
});

Expand Down
2 changes: 1 addition & 1 deletion packages/studio/src/components/editor/CanvasContextMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ export const CanvasContextMenu = memo(function CanvasContextMenu({
return createPortal(
<div
ref={menuRef}
className="fixed z-50 bg-neutral-900 border border-neutral-700 rounded-md shadow-lg py-1 min-w-[180px]"
className="fixed z-[200] bg-neutral-900 border border-neutral-700 rounded-md shadow-lg py-1 min-w-[180px]"
style={{ left: adjustedX, top: adjustedY }}
onPointerDown={stopBubble}
onMouseDown={stopBubble}
Expand Down
2 changes: 1 addition & 1 deletion packages/studio/src/components/editor/TimelineFxPopover.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ describe("TimelineFxPopover", () => {
const dialog = withViewportHeight(200, () =>
dialogOf(mount({ anchorRect: rect(100, 120) }).host),
);
// bottom:32 + maxHeight:160 puts the box at y = 8..40 — a margin on each side.
// bottom:32 + maxHeight:160 puts the box at y = 8..168 — a margin on each side.
expect(dialog.style.bottom).toBe("32px");
const bottom = Number.parseFloat(dialog.style.bottom);
const height = Number.parseFloat(dialog.style.maxHeight);
Expand Down
2 changes: 1 addition & 1 deletion packages/studio/src/components/editor/TimelineFxPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export function TimelineFxPopover({
ref={rootRef}
role="dialog"
aria-label="Effects"
className="z-50 flex flex-col overflow-hidden rounded-md border border-white/10 bg-[#1b1b1f] p-2 shadow-xl"
className="z-[200] flex flex-col overflow-hidden rounded-md border border-white/10 bg-[#1b1b1f] p-2 shadow-xl"
style={clampedStyle(anchorRect)}
onKeyDown={onKeyDown}
onPointerDown={(event) => event.stopPropagation()}
Expand Down
2 changes: 1 addition & 1 deletion packages/studio/src/player/components/AutomationSelectionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const AutomationSelectionMenu = memo(function AutomationSelectionMenu({
return createPortal(
<div
ref={menuRef}
className="hf-automation-menu fixed z-50 min-w-[140px] rounded border border-panel-border-input bg-panel-bg-2 py-1 shadow-lg"
className="hf-automation-menu fixed z-[200] min-w-[140px] rounded border border-panel-border-input bg-panel-bg-2 py-1 shadow-lg"
style={{ left: adjustedX, top: adjustedY }}
>
{AUTOMATION_SHAPES.map((shape) => (
Expand Down
2 changes: 1 addition & 1 deletion packages/studio/src/player/components/ClipContextMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const ClipContextMenu = memo(function ClipContextMenu({
ref={menuRef}
role="menu"
aria-label="Clip actions"
className="fixed z-50 bg-neutral-900 border border-neutral-700 rounded-md shadow-lg py-1 min-w-[180px]"
className="fixed z-[200] bg-neutral-900 border border-neutral-700 rounded-md shadow-lg py-1 min-w-[180px]"
style={{ left: adjustedX, top: adjustedY }}
>
{splitLabel && (
Expand Down
2 changes: 1 addition & 1 deletion packages/studio/src/player/components/KeyframeDiamondContextMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export function KeyframeDiamondContextMenu({
ref={menuRef}
role="menu"
aria-label="Keyframe actions"
className="fixed z-50 bg-neutral-900 border border-neutral-700 rounded-md shadow-lg py-1 min-w-[180px] overflow-y-auto"
className="fixed z-[200] bg-neutral-900 border border-neutral-700 rounded-md shadow-lg py-1 min-w-[180px] overflow-y-auto"
style={{ left: adjustedX, top: adjustedY, maxHeight: `calc(100vh - ${adjustedY + 8}px)` }}
>
{onMoveToPlayhead && (
Expand Down
2 changes: 1 addition & 1 deletion packages/studio/src/player/components/TimelineFxButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export function TimelineFxButton(props: TimelineFxButtonProps) {
<div
role="dialog"
aria-label="Group these clips to add effects"
className="z-50 w-56 rounded-md border border-white/10 bg-[#1b1b1f] p-2.5 text-[11px] text-white/75 shadow-xl"
className="z-[200] w-56 rounded-md border border-white/10 bg-[#1b1b1f] p-2.5 text-[11px] text-white/75 shadow-xl"
style={{ position: "fixed", left: anchorRect.left, top: anchorRect.bottom + 4 }}
onPointerDown={(event) => event.stopPropagation()}
>
Expand Down
2 changes: 1 addition & 1 deletion packages/studio/src/player/components/TrackGapContextMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export const TrackGapContextMenu = memo(function TrackGapContextMenu({
return createPortal(
<div
ref={menuRef}
className="fixed z-50 bg-neutral-900 border border-neutral-700 rounded-md shadow-lg py-1 min-w-[180px]"
className="fixed z-[200] bg-neutral-900 border border-neutral-700 rounded-md shadow-lg py-1 min-w-[180px]"
style={{ left: adjustedX, top: adjustedY }}
onPointerLeave={() => onHoverAction(null)}
>
Expand Down
Loading