fix(cli): hide detached Windows spawns - #3478
Draft
kvnloo wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windowsHide: trueto telemetry exit flush, custom browser launch, and background preview detached spawnsFixes #3476
Verification
bun run --filter @hyperframes/cli test -- src/telemetry/client.test.ts src/utils/openBrowser.test.ts src/commands/previewLifecycle.test.ts(61 passed)bun run --filter @hyperframes/cli typecheckbun run lintbun run format:checkbun run buildgit diff --checkwindowsHidefromopenBrowsermade its new regression test failThe full
bun run testis not clean in this environment. Studio has 97 failures caused primarily by unavailablelocalStorage, and the full CLI run has 3 unrelatedskillsManifest.test.tslock-pruning failures. The focused tests for all changed paths pass.Windows real-device validation has not been performed.
Scope
This does not change ffmpeg handling from #3379 or chrome-headless-shell handling from #3430. It does not add a shared spawn helper or lint rule.
AI assistance
Implemented and verified with Hermes Agent using Codex. I reviewed the resulting diff and test evidence.