fix(lint): reject timeline content beyond render duration - #3560
Closed
L1337H wants to merge 1 commit into
Closed
Conversation
Author
|
@miguel-heygen could you please approve the fork workflows and review this focused lint fix? Local lint, build, 542 lint-package tests, a 1,023-composition compatibility scan, and the CLI fail/pass repro are all green. |
miguel-heygen
approved these changes
Aug 31, 2026
miguel-heygen
enabled auto-merge (squash)
August 31, 2026 15:57
Author
|
@miguel-heygen all required checks are green and the PR is approved. GitHub will not allow me to merge or enable auto-merge because the base-branch policy requires maintainer permissions. Could you merge it when convenient? Once merged, I will continue with the release and Fiona Dev rollout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
An explicit root
data-durationis the hard export boundary. Previously, a child could extend far beyond it whilehyperframes checkstill passed, so previews or snapshots could make unreachable timeline content look valid before export truncated it.Verification
bun run --cwd packages/lint test— 542 passedbun run buildbun run lintbun run --cwd packages/lint typecheckhyperframes check --jsonwithtimed_element_exceeds_composition; shortening the child to 10s passes the full check