Skip to content

fix(producer): degrade gracefully when font cache directory is unwritable #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miga-heygen merged 3 commits into from
Sep 3, 2026
Merged

fix(producer): degrade gracefully when font cache directory is unwritable #3572

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8035709
fix(producer): degrade gracefully when font cache directory is unwrit…
miga-heygen Aug 31, 2026
db15463
fix: use mkdtempSync for font cache fallback, restore warning
miga-heygen Aug 31, 2026
6ea0e7d
fix: emit font cache fallback warning once per run, not per font
miga-heygen Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/producer/src/services/deterministicFonts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,13 @@
function fontCacheDir(slug: string): string {
const dir = join(resolveFontCacheRoot(), slug);
if (!existsSync(dir)) {
mkdirSync(dir, { recursive: true });
try {
mkdirSync(dir, { recursive: true });
} catch {
const fallback = join(tmpdir(), `hyperframes-fonts-fallback`, slug);
mkdirSync(fallback, { recursive: true });
return fallback;
}
}
return dir;
}
Expand Down Expand Up @@ -1047,7 +1053,7 @@
if (!fontResult.ok) return null;
// wx = O_CREAT|O_EXCL: atomic create, rejects symlinks, fails with
// EEXIST if a concurrent call cached it between our read and write.
writeFileSync(cachePath, Buffer.from(fontResult.body), { flag: "wx", mode: 0o644 });

Check failure

Code scanning / CodeQL

Insecure temporary file High

Insecure creation of file in
the os temp dir
Loading
.
} catch (err) {
throwIfCallerAborted(options.abortSignal);
if (err instanceof FontFetchError) throw err;
Expand Down
Loading