Lighten review routing and gate semantics: ordinary review by default, P0/P1-only blocking, scoped re-review#18
Merged
Conversation
Max review stops being the default merge-gate path: routing narrows to explicit asks, high-risk changes, and large branches; the gate blocks on P0/P1 only with P2 routed to human adjudication; post-fix re-review is scoped to the fix wave. review-protocol.md untouched. Includes updated restatements (requesting-code-review, subagent-driven-development), README, integration-test assertions, new pressure scenarios, and evidence records. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JdezWcnXee9zEU3jH2cA1X
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR? (required)
claude-fable-5superpowers@superpowers-dev(this fork, working tree),commit-commands,claude-md-managementWhat problem are you trying to solve?
The max review pipeline had become the default path for every merge, and the gate semantics doubled its cost:
requesting-code-reviewlisted "PR review, branch review, merge-gate review" as max triggers while "before merge to main" is mandatory — so every branch merge, however small, ran the 11-angle fan-out protocol. Live baseline: both harnesses ran the full max protocol for a routine two-file, low-risk helper diff (docs/superpowers/evidence/code-review/2026-07-11-routing-default-before-*.md).2026-07-11-gate-p2-before-*.md).evaluation.mdalready documents P1↔P2 label swaps between runs on identical diffs, so a blocking-on-P2 gate can re-block on relabeling alone.evaluation.mdbaseline and the existing followup entry), so the heavy default was not backed by recall evidence.What does this PR change?
Narrows max-review routing to explicit asks, high-risk changes (auth, migration, contracts, concurrency, payments), and large branches; makes the gate block on P0/P1 only, with P2 routed to human adjudication (fix now or track, never silently dropped); scopes post-fix re-review to the fix wave, reserving full reruns for broad fixes.
review-protocol.mdis untouched (pinned digest unchanged); the shell SKILL.md,requesting-code-review,subagent-driven-developmentrestatements, README line, integration test, pressure scenarios, evaluation records, and a followups entry are updated together.Is this change appropriate for the core library?
Yes — it tunes the fork's existing general-purpose review-gate wiring (introduced in this fork, not upstream). No new dependencies, no domain-specific content. Not intended for upstream as-is: upstream does not carry this gate wiring.
What alternatives did you consider?
review-protocol.md, which carries a pinned digest and a higher evidence bar. Routing + gate semantics live in the shell and account for the observed cost.Does this PR contain multiple unrelated changes?
No. All edits implement or document the single routing/gate-semantics change; the one followups.md entry added for an unrelated test-infrastructure observation (locale-sensitive tests) is registration-only, per this fork's followups convention (issues are disabled).
Existing PRs
Environment tested
claude-opus-4-8[1m]gpt-5.6-solEvidence
Before/after live transcripts for the two new pressure scenarios (routing, gate-p2) plus regression reruns of scenarios 1-2 (planted-bug recall, clean-diff honesty) on both harnesses — all after-runs PASS their criteria, both planted bugs still found under explicit invocation — recorded in
skills/code-review/evaluation.mdwith transcripts underdocs/superpowers/evidence/code-review/. Deterministic checks:tests/code-review-skill/test-code-review-integration.shSTATUS PASSED (77 assertions, updated to pin the new contract, including threeassert_not_containsnegatives against the old P2-blocking wording); both SDD dot graphs validate with graphviz;review-protocol.mdsha256 unchanged against the pinned digest. An independent reviewer subagent (Claude Opus 4.8) reviewed the full diff — 1 Important + 3 Minor findings, all fixed and re-verified with zero remaining findings. Known-broken environmental test documented in followups.md (locale-sensitivetests/claude-codeassertions, reproduced on the untouched pre-edit tree).New harness support
N/A — no new harness.