Skip to content

Selenium failing to realize when page loads at "And I click 'btnG' button and wait" #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alanjds wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Selenium failing to realize when page loads at "And I click 'btnG' button and wait" #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyccuracy/actions/core/element_actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def execute(self, context, element_type, element_name, should_wait):
context.browser_driver.click_element(element_key)

if (should_wait):
timeout = 30000
timeout = 5000
try:
context.browser_driver.wait_for_page(timeout=timeout)
except Exception, error:
Expand Down
9 changes: 6 additions & 3 deletions pyccuracy/drivers/core/selenium_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,11 @@ def resolve_element_key(self, context, element_type, element_key):
def page_open(self, url):
self.selenium.open(url)

def wait_for_page(self, timeout=30000):
self.selenium.wait_for_page_to_load(timeout)
def wait_for_page(self, timeout=5000):
try:
self.selenium.wait_for_page_to_load(timeout)
except Exception, e: # Selenium is not perceiving some loads, so ignore it
pass

def click_element(self, element_selector):
self.selenium.click(element_selector)
Expand Down Expand Up @@ -287,4 +290,4 @@ def __str__(self):
def __unicode__(self):
return "SeleniumDriver at '%s:%s' using '%s' browser." % (self.context.settings.extra_args.get("selenium.server", "localhost"),
self.context.settings.extra_args.get("selenium.port", 4444),
self.context.settings.browser_to_run)
self.context.settings.browser_to_run)