Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quantity repr #1579

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update quantity repr #1579

wants to merge 2 commits into from

Conversation

jules-ch
Copy link
Collaborator

  • Closes Quantity repr #1495

  • Executed pre-commit run --all-files with no errors

  • The change is fully covered by automated unit tests

  • Documented in docs/ as appropriate

  • Added an entry to the CHANGES file

  • Update CHANGES

  • Add test for repr

  • Update repr function to include magnitude repr & units

@andrewgsavage
Copy link
Collaborator

any reason this wasn't merged for the last releases?

Copy link

codspeed-hq bot commented Jun 22, 2024

CodSpeed Performance Report

Merging #1579 will not alter performance

Comparing jules-ch:quantity-repr (9c082fa) with master (b436902)

Summary

✅ 437 untouched benchmarks

@jules-ch
Copy link
Collaborator Author

Gonna rebase and I think we can merge this.
@andrewgsavage @hgrecco

- Update CHANGES
- Add test for repr
- Update repr function to include magnitude repr & units
@jules-ch jules-ch force-pushed the quantity-repr branch 3 times, most recently from 9eeeb2a to 4fdaa41 Compare December 13, 2024 19:21
@jules-ch
Copy link
Collaborator Author

is there a reason why we are using only 6 decimals for float.
repr of float is already truncating things

@andrewgsavage
Copy link
Collaborator

not that I am aware of. what would be best for the repr? I'd just use the repr of the float

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quantity repr
2 participants