HHH-19861 Fix EntityNotFoundException when using targetAuditMode NOT_AUDITED on FK fields #11114
+531
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also added tests to check that the |
Aftermoon-dev
force-pushed
the
HHH-19861
branch
2 times, most recently
from
f0bc636 to
726e004
Compare
Aftermoon-dev
force-pushed
the
HHH-19861
branch
from
726e004 to
195e15d
Compare
Contributor
Author
|
I migrated my test code to JUnit 5 😄 |
mbellade
reviewed
Jan 8, 2026
Member
mbellade
left a comment
mbellade
left a comment
There was a problem hiding this comment.
Thanks @Aftermoon-dev, left a couple comments but the overall idea looks fine. It's weird that this target audit mode is completely ignored apart from a single place in the code where we perform a check on the mapping's consistency.
...vers/src/main/java/org/hibernate/envers/internal/entities/mapper/relation/ToOneIdMapper.java
Outdated
Show resolved
Hide resolved
...ava/org/hibernate/envers/configuration/internal/metadata/ToOneRelationMetadataGenerator.java
Outdated
Show resolved
Hide resolved
Aftermoon-dev
force-pushed
the
HHH-19861
branch
2 times, most recently
from
5137727 to
2ebae6a
Compare
Aftermoon-dev
changed the title
mbellade
reviewed
Jan 12, 2026
Member
mbellade
left a comment
mbellade
left a comment
There was a problem hiding this comment.
Almost good @Aftermoon-dev, also please squash everything to 1-2 commits.
...vers/src/main/java/org/hibernate/envers/internal/entities/mapper/relation/ToOneIdMapper.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/hibernate/envers/internal/entities/mapper/relation/ToOneEntityLoader.java
Outdated
Show resolved
Hide resolved
...vers/src/main/java/org/hibernate/envers/internal/entities/mapper/relation/ToOneIdMapper.java
Outdated
Show resolved
Hide resolved
Aftermoon-dev
force-pushed
the
HHH-19861
branch
2 times, most recently
from
24a7525 to
f386db9
Compare
Contributor
Author
@mbellade Thank you for your review! I updated it and squash to 1 commit 😄 |
Aftermoon-dev
force-pushed
the
HHH-19861
branch
from
f386db9 to
47a9057
Compare
…AUDITED on FK fields
Aftermoon-dev
force-pushed
the
HHH-19861
branch
from
47a9057 to
64302d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-19861
In
internal/entities/mapper/relation/ToOneEntityLoader.java->loadImmediatemethod checks@NotAuditedthroughenversService.getEntitiesConfigurations().getNotVersionEntityConfiguration( entityName ) == null, but if set@Audited (targetAuditMode = RelationshipTargetAuditMode.NOT_AUDITED)in FK, it seems that the reason is that it is not checked.I updated
loadImmediateMethod to check that part.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.