HHH-20009 Fix docker_db.sh for Apple Silicon & fix env var typo #11486
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namuuCY
force-pushed
the
docker-shell
branch
2 times, most recently
from
60dcfe8 to
e9c2cda
Compare
beikov
approved these changes
Dec 22, 2025
Member
beikov
left a comment
beikov
left a comment
There was a problem hiding this comment.
LGTM, though we should probably define these platform options more globally and use them for all postgresql versions.
- Added --platform linux/amd64 to postgres(Applied globally) functions for macOS environment. The current postgis images lack ARM64 manifests, requiring amd64 emulation via Rosetta 2. - Fixed a typo in postgresql_18 function referencing the wrong environment variable (_17 -> _18). Signed-off-by: namucy <[email protected]>
namuuCY
force-pushed
the
docker-shell
branch
from
e9c2cda to
fb08510
Compare
Contributor
Author
|
@beikov I realized that previous versions (13-16) were also pulling I have updated the PR to apply this to all PostgreSQL versions. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where
docker_db.shfails to pull PostgreSQL 17/18 images on Apple Silicon (ARM64) devices due to missing ARM64 manifests in thepostgis/postgisimage.Changes
--platform linux/amd64flag for PostgreSQL(applied globally) containers when running on macOS (IS_OSX). This forces Rosetta 2 emulation on ARM Macs and is safe for Intel Macs.postgresql_18function (DB_IMAGE_POSTGRESQL_17->DB_IMAGE_POSTGRESQL_18).Verification
postgresql,postgresql_13~postgresql_18starts successfully with this change.IS_OSX).Related Jira Issue
https://hibernate.atlassian.net/browse/HHH-20009
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.