lots of cleanups and minor refactorings to results stuff #11548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add type param to EntityResult
and start looking into BasicResultAssembler casts
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
gavinking
force-pushed
the
bigchset
branch
2 times, most recently
from
ded0c52 to
2cf8fcb
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| final GeneratedValues generatedValues = identifierDelegate.performInsertReturning( | ||
| final var identifierDelegate = (InsertGeneratedIdentifierDelegate) insertDelegate; | ||
| final var jdbcValueBinder = basicIdentifierMapping.getJdbcMapping().getJdbcValueBinder(); | ||
| for ( var entry : entityTableToRootIdentity.entrySet() ) { |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
Comment on lines
+167
to
+168
| final Map<Fetchable, FetchBuilder> fetchBuilderMap = | ||
| new HashMap<>( this.fetchBuilderMap.size() ); |
Check notice
Code scanning / CodeQL
Possible confusion of local and field Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.