Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBX-2390: Create a JBoss Tools adaptation layer in Hibernate Tools #4280

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

koentsje
Copy link
Member

@koentsje koentsje commented Jul 3, 2023

  • Change class 'org.hibernate.tool.orm.jbt.wrp.TableWrapper' into an interface
  • Create new class 'org.hibernate.tool.orm.jbt.wrp.DelegatingTableWrapperImpl' that extends Table and implements TableWrapper
  • Modify methods in class 'org.hibernate.tool.orm.jbt.wrp.DelegatingPersistentClassWrapperImpl' to wrap the result
    • DelegatingPersistentClassWrapperImpl#getRootClass()
    • DelegatingPersistentClassWrapperImpl#getTable()
  • Handle the 'getAssociatedClass()' case in 'org.hibernate.tool.orm.jbt.wrp.ValueWrapperFactory.ValueWrapperInvocationHandler' to wrap the resulting PersistentClass instance
  • Modify method 'org.hibernate.tool.orm.jbt.wrp.createTableWrapper(String)' to create an instance of DelegatingTableWrapperImpl
  • Rename class 'org.hibernate.tool.orm.jbt.wrp.TableWrapperTest' into 'org.hibernate.tool.orm.jbt.wrp.DelegatingTableWrapperImpl' and adapt to the new implementation
  • Add some methods to class 'org.hibernate.tool.ide.completion.HQLCompletionProposal
    • aliasRefKind()
    • entityNameKind() * propertyKind() * keywordKind() * functionKind()

  - Change class 'org.hibernate.tool.orm.jbt.wrp.TableWrapper' into an interface
  - Create new class 'org.hibernate.tool.orm.jbt.wrp.DelegatingTableWrapperImpl' that extends Table and implements TableWrapper
  - Modify methods in class 'org.hibernate.tool.orm.jbt.wrp.DelegatingPersistentClassWrapperImpl' to wrap the result
    * DelegatingPersistentClassWrapperImpl#getRootClass()
    * DelegatingPersistentClassWrapperImpl#getTable()
  - Handle the 'getAssociatedClass()' case in 'org.hibernate.tool.orm.jbt.wrp.ValueWrapperFactory.ValueWrapperInvocationHandler' to wrap the resulting PersistentClass instance
  - Modify method 'org.hibernate.tool.orm.jbt.wrp.createTableWrapper(String)' to create an instance of DelegatingTableWrapperImpl
  - Rename class 'org.hibernate.tool.orm.jbt.wrp.TableWrapperTest' into 'org.hibernate.tool.orm.jbt.wrp.DelegatingTableWrapperImpl' and adapt to the new implementation
  - Add some methods to class 'org.hibernate.tool.ide.completion.HQLCompletionProposal
    * aliasRefKind()
    * entityNameKind()
    * propertyKind()
    * keywordKind()
    * functionKind()

Signed-off-by: Koen Aers <[email protected]>
@koentsje koentsje merged commit d5c5a26 into hibernate:main Jul 3, 2023
3 checks passed
@koentsje koentsje deleted the HBX-2390 branch July 3, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant