Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to the last stable FileHelpers Version 3.0.46 #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

MarcosMeli
Copy link

I just updated the library and the NuGet build script for use the last version of the FileHelpers library that must run much better and faster now

Based on:

#12

@@ -78,7 +78,7 @@ task Nuget {
@("RhinoDSL", "1.0.0"), `
@("Common.Logging", "3.0.0"), `
@("Common.Logging.Core", "3.0.0"), `
@("FileHelpers", "2.0.0.0") `
@("FileHelpers", "3.0.46-beta") `

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work, see error @MarcosMeli :
A stable release of a package should not have on a prerelease dependency. Either modify the version spec of dependency "FileHelpers (= 3.0.46-beta)" or update the version field.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@regisbsb If you change it for: @("FileHelpers", "=3.0.46-beta") ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'=3.0.46-beta' is not a valid version string.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fount it http://docs.nuget.org/create/versioning

You must use: @("FileHelpers", "[3.0.46-beta]")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like even with using the bracket notation that Nuget isn't allowing the build to happen. We're still getting the same Prerelease dependency error.

@MarcosMeli, when do you plan on removing the -beta tag from 3.0.46?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, we are planning to release 3.1 final version in the next two weeks, we released 3.1-rc now, the binaries will be near the same because we are no planning changes, only finishing the new site and docs in www.filehelpers.net

I will send a new pull request after we release final 3.1
Best Regards

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcosMeli if you could refresh the dll in the SharedLibs folder and update the default.ps1 in your branch I think your pull request will be more successful then mine. Any way if my pull request is accepted I've already prepared a "nugetified" version of the update as well on my branch that is mergeable as well.

@MarcosMeli
Copy link
Author

Final version 3.1.2 released, I will close this PR because work continues on: #25

@MarcosMeli MarcosMeli closed this Aug 3, 2015
@regisbsb
Copy link

regisbsb commented Aug 3, 2015

@MarcosMeli I'd suggest that you don't close this as your PR is much more subtle than mine it will be accepted easier. It's a simple change on your PR as well.

@regisbsb regisbsb mentioned this pull request Aug 3, 2015
@MarcosMeli MarcosMeli reopened this Aug 3, 2015
@MarcosMeli
Copy link
Author

Reopened and updated 👍

@regisbsb
Copy link

regisbsb commented Aug 9, 2015

:shipit: @nathanpalmer 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants