This repository has been archived by the owner on Nov 9, 2021. It is now read-only.
Don't parse/stringify default configs every time (Performance improvement) #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed old issues about performance concerns, and in profiling my own application, I also observed significant time spent within squel, particularly when creating lots of queries. While there are a few places that are unoptimized (all of the Object.getOwnPropertyNames can really bog stuff down), the biggest culprit that I personally noticed was using JSON.parse and JSON.stringify to clone the configs in the base builder constructor. This was taking much longer than actually fetching my queries from the database/cache. So, in this PR, I've refactored the default options to be a function returning an object instead of an object, and the dialect-specific classes override this with the appropriate options.
Stylistically, it's definitely a bit uglier than just having an option, but I've found it to be a >2x speedup, so it's worth it to me. Feel free to suggest other ways of eliminating the costly parsing and stringification as well.