Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixbug] Fix graph metadata hash #428

Merged
merged 3 commits into from
Mar 4, 2024
Merged

[Fixbug] Fix graph metadata hash #428

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6268e28
fix graph metadata hash
KTong821 Feb 20, 2024
12d404c
determinism
KTong821 Feb 24, 2024
4cfe981
lint
KTong821 Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/hidet/drivers/build_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ def get_graph_meta_data(graph: FlowGraph, num_kernels, space: int) -> GraphMetaD
lines.append(str(node.task))
lines.append(str(graph))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this line produce different string when the topological order is different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think anything that relies on graph.nodes will cause this.

lines.append(str(space))

# graph nodes are not traversed in deterministic order
# sort to ensure same graph --> same hash
lines.sort()

graph_hash = sha256('\n'.join(lines).encode('utf-8')).hexdigest()[:16]

return GraphMetaData(
Expand Down
Loading