Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app and services to stop querying the platform for the roster #16771

Merged

Conversation

MiroslavGatsanoga
Copy link
Contributor

@MiroslavGatsanoga MiroslavGatsanoga commented Nov 25, 2024

Description:

Remove Platform.getRoster() calls from Services code.

Related issue(s):

Fixes #16721

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@MiroslavGatsanoga MiroslavGatsanoga added this to the v0.58 milestone Nov 25, 2024
@MiroslavGatsanoga MiroslavGatsanoga self-assigned this Nov 25, 2024
Copy link

codacy-production bot commented Nov 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b17a761) 98558 71831 72.88%
Head commit (d0d18f7) 98559 (+1) 71847 (+16) 72.90% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16771) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.95%. Comparing base (b17a761) to head (d0d18f7).
Report is 18 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #16771      +/-   ##
============================================
+ Coverage     68.93%   68.95%   +0.01%     
- Complexity    22853    22861       +8     
============================================
  Files          2630     2630              
  Lines         98775    98776       +1     
  Branches      10256    10256              
============================================
+ Hits          68091    68107      +16     
+ Misses        26792    26777      -15     
  Partials       3892     3892              
Files with missing lines Coverage Δ
...-app/src/main/java/com/hedera/node/app/Hedera.java 50.36% <100.00%> (+0.24%) ⬆️
...a/com/hedera/node/app/platform/PlatformModule.java 100.00% <ø> (ø)
...edera/node/app/throttle/ThrottleServiceModule.java 100.00% <100.00%> (ø)
...app/workflows/standalone/TransactionExecutors.java 91.20% <100.00%> (ø)

... and 11 files with indirect coverage changes

Impacted file tree graph

@MiroslavGatsanoga MiroslavGatsanoga force-pushed the 16721-services-stop-querying-platform-for-roster branch from 0a177a5 to 20a5ea8 Compare November 25, 2024 14:07
Neeharika-Sompalli and others added 24 commits November 25, 2024 18:05
Signed-off-by: Neeharika-Sompalli <[email protected]>
… initializing states api

Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
@MiroslavGatsanoga MiroslavGatsanoga force-pushed the 16721-services-stop-querying-platform-for-roster branch from 70f1ab8 to 8d779d3 Compare January 29, 2025 17:54
imalygin
imalygin previously approved these changes Jan 29, 2025
@MiroslavGatsanoga MiroslavGatsanoga modified the milestones: v0.58, v0.60 Jan 30, 2025
@edward-swirldslabs
Copy link
Contributor

so much cleaner to review.

Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @MiroslavGatsanoga !

@MiroslavGatsanoga MiroslavGatsanoga merged commit b45fac5 into main Feb 4, 2025
46 checks passed
@MiroslavGatsanoga MiroslavGatsanoga deleted the 16721-services-stop-querying-platform-for-roster branch February 4, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The app and services stop querying the platform for the address book or roster.
7 participants