-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: app and services to stop querying the platform for the roster #16771
fix: app and services to stop querying the platform for the roster #16771
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16771 +/- ##
============================================
+ Coverage 68.93% 68.95% +0.01%
- Complexity 22853 22861 +8
============================================
Files 2630 2630
Lines 98775 98776 +1
Branches 10256 10256
============================================
+ Hits 68091 68107 +16
+ Misses 26792 26777 -15
Partials 3892 3892
|
Signed-off-by: Miroslav Gatsanoga <[email protected]>
0a177a5
to
20a5ea8
Compare
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
… initializing states api Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
hedera-node/hedera-app/src/main/java/com/hedera/node/app/Hedera.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Miroslav Gatsanoga <[email protected]>
70f1ab8
to
8d779d3
Compare
so much cleaner to review. |
Signed-off-by: Miroslav Gatsanoga <[email protected]>
d0d18f7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @MiroslavGatsanoga !
Description:
Remove
Platform.getRoster()
calls from Services code.Related issue(s):
Fixes #16721
Checklist