Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Additional Airdrop to Contracts e2e test cases #16778

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

stoyanov-st
Copy link
Contributor

Description:

This PR aims to include additional test cases for Airdrops to Contracts.
This PR also adds additional overloaded helper methods for reusability and ease of testing.

Related issue(s):

Fixes #16248
Fixes #16249
Fixes #16250
Fixes #16251
Fixes #16252
Fixes #16253
Fixes #16254
Fixes #16255

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@stoyanov-st stoyanov-st added this to the v0.58 milestone Nov 25, 2024
@stoyanov-st stoyanov-st self-assigned this Nov 25, 2024
@stoyanov-st stoyanov-st requested review from a team as code owners November 25, 2024 17:26
Copy link

codacy-production bot commented Nov 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c780fb6) 97916 64158 65.52%
Head commit (935a526) 97916 (+0) 64156 (-2) 65.52% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16778) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.82%. Comparing base (c780fb6) to head (935a526).
Report is 26 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16778      +/-   ##
=============================================
- Coverage      63.82%   63.82%   -0.01%     
+ Complexity     20551    20549       -2     
=============================================
  Files           2540     2540              
  Lines          95151    95151              
  Branches        9941     9941              
=============================================
- Hits           60729    60726       -3     
- Misses         30803    30805       +2     
- Partials        3619     3620       +1     

see 1 file with indirect coverage changes

Impacted file tree graph

Copy link
Contributor

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoyanov-st stoyanov-st merged commit 1bece08 into develop Dec 9, 2024
45 of 46 checks passed
@stoyanov-st stoyanov-st deleted the 15596-airdrop-to-contracts-e2e branch December 9, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants