feat: deprecate debug [timestamp] command#868
Merged
Conversation
Signed-off-by: nikolay <n.atanasow94@gmail.com>
natanasow
added
the
Improvement
natanasow
requested review from
a team,
Ivo-Yankov,
georgi-l95,
konstantinabl and
victor-yanev
as code owners
natanasow
changed the title
debug [timestamp] commanddebug [timestamp] command
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
- Coverage 62.89% 61.15% -1.75%
==========================================
Files 30 29 -1
Lines 1237 1179 -58
Branches 149 147 -2
==========================================
- Hits 778 721 -57
+ Misses 438 437 -1
Partials 21 21
|
Signed-off-by: nikolay <n.atanasow94@gmail.com>
|
Ivo-Yankov
approved these changes
Dec 3, 2024
jeromy-cannon
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The local node had supported the
debug [timestamp]command which returned the parsed record file for that timestamp. It used service's classes from the mono repo. After the modularization, the command stopped working due to changing/deleting the parser files.Solution:
The command can be deprecated because all the data is available in the mirror node explorer. This will reduce the local-node's complexity and codebase, making it more lightweight.
Related issue(s):
Fixes #862
Notes for reviewer:
Checklist