Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated transaction IDs are not unique issue small updates #1605

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

thenswan
Copy link
Contributor

Description:
Small updates, based on the review of #1587.

Related issue(s):
Fixes #1557

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f463b7d) 82.26% compared to head (effd3e9) 82.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1605   +/-   ##
==========================================
  Coverage      82.26%   82.27%           
- Complexity      3590     3591    +1     
==========================================
  Files            186      186           
  Lines          11692    11692           
  Branches        1148     1148           
==========================================
+ Hits            9619     9620    +1     
  Misses          1598     1598           
+ Partials         475      474    -1     
Files Changed Coverage Δ
...n/java/com/hedera/hashgraph/sdk/TransactionId.java 69.60% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@thenswan thenswan merged commit d7096b3 into develop Sep 12, 2023
@thenswan thenswan deleted the updates-for-transactionid branch September 12, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated transaction IDs are not unique
3 participants