Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DUPLICATE_TRANSACTION error for Queries #2190

Merged
merged 15 commits into from
Feb 4, 2025
Merged

fix: DUPLICATE_TRANSACTION error for Queries #2190

merged 15 commits into from
Feb 4, 2025

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Jan 23, 2025 •
edited
Loading

Description:

This PR changes:

  1. Makes running integration tests in parallel, with workers equal to the machine cores.
  2. Removes the Thread.sleep during ContractFunctionParametersIntegrationTest, which causes the consensus node to return BUSY
  3. When the SDK gets status BUSY from the network, we generate new payment transaction ID, this prevents having duplicate transactions.
  4. Introduces re-submission for a given transaction, when THROTTLED_AT_CONSENSUS occures.

Related issue(s):

Fixes #

Notes for reviewer:

  1. Before this change, the integration tests took 11-13 min, now they take under 5.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov
fix: duplicate transaction
71a8364 
Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov
chore: fix contract function tests
d41e7f0 
Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov
chore: spotless
2639cc9 
Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov self-assigned this Jan 23, 2025
@0xivanov 0xivanov marked this pull request as ready for review February 3, 2025 14:38
@0xivanov 0xivanov requested review from a team as code owners February 3, 2025 14:38
andrewb1269hg
andrewb1269hg approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve sdk/build.gradle.kts

@0xivanov 0xivanov merged commit 49eb915 into main Feb 4, 2025
6 checks passed
@0xivanov 0xivanov deleted the fix-duplicate-transaction-for-queries branch February 4, 2025 12:27
@0xivanov 0xivanov mentioned this pull request Feb 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naydenovn naydenovn naydenovn approved these changes

@agadzhalov agadzhalov agadzhalov approved these changes

@andrewb1269hg andrewb1269hg andrewb1269hg approved these changes

@mishomihov00 mishomihov00 mishomihov00 approved these changes

Assignees

@0xivanov 0xivanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xivanov @naydenovn @agadzhalov @andrewb1269hg @mishomihov00