chore: Update hiero conventions #2206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
|
@jjohannes Do you think merging this would fix https://github.com/hiero-ledger/hiero-sdk-java/actions/runs/13071506171/job/36474073957?pr=2205 , as we did before? |
|
@0xivanov not sure. I commented on the other PR what you can do to make sure we do not hit the bug. |
jjohannes
requested changes
Jan 31, 2025
| @@ -31,7 +31,7 @@ testModuleInfo { | |||
| requires("org.junit.jupiter.params") | |||
| requires("org.mockito") | |||
|
|
|||
| requiresStatic("java.annotation") | |||
| requires("java.annotation") | |||
There was a problem hiding this comment.
Suggested change
| requires("java.annotation") |
This entry can and should now be removed completely the "test scope" inherits this from the "main scope" and this is now respected by the analysis. It should not suggest to add something else. I will have to check what's wrong there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.