Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Streamline key and alias specifications for AccountCreateTransaction #2210

Merged
merged 39 commits into from
Feb 5, 2025
Merged

feat: Streamline key and alias specifications for AccountCreateTransaction #2210

merged 39 commits into from
Feb 5, 2025

Conversation

naydenovn
Copy link
Contributor

@naydenovn naydenovn commented Feb 3, 2025 •
edited by 0xivanov
Loading

Description:

This PR extends the AccountCreateTransaction with the following APIs:

  • setKeyWithAlias(ECDSAKey) - Sets ECDSA private key, derives and sets it's EVM address in the background.
  • setKeyWithAlias(Key, ECDSAKey) - Allows for setting the account key and a separate ECDSA private key that the EVM address should be derived from. A user must sign the transaction with both keys for this flow to be successful.
  • setKeyWithoutAlias(Key) - Explicitly calls out that the alias is not set.

🚨 Deprecation Notice:

  • setKey(Key) is now deprecated in favor of setKeyWithAlias and setKeyWithoutAlias.

Fixes : #2177

naydenovn and others added 28 commits January 20, 2025 15:15
@naydenovn
feat: introduce new mechanism for key setting when creating an account
92e51a0 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
fix: AccountCreateTransaction modifications + adjusted IT
2c7a440 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
Merge branch 'refs/heads/main' into 1219-Streamline-key-and-alias-spe…
834f81f 
…cifications-for-AccountCreateTransaction
@naydenovn
fix: spotlessApply
dfca958 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
feat: introduce new integration tests and example
c8edf5e 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
fix: spotlessApply
e108ef3 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
Merge branch 'main' into 1219-Streamline-key-and-alias-specifications…
5c50645 
…-for-AccountCreateTransaction
@naydenovn
fix: spotlessApply
3505c82 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
fix: recreate snapshot
68fc740 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
fix: recreate snapshot
6a9cd83 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
fix: resolve pr comments
05ad3da 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
fix: IT
2aa3c20 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
fix: IT and adjust example to comply with criteria
5ae4850 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
fix: IT
9cc35c8 
Signed-off-by: Naydenov <[email protected]>
@0xivanov
chore: refactor
90512cd 
Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov
chore: make key a constant
1d249ab 
Signed-off-by: Ivan Ivanov <[email protected]>
@naydenovn
fix: spotlessApply
b6686ec 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
feat: introduce new mechanism for TokenRejectFlow
6c009a4 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
Merge branch '2189-refactor-transaction-flows-to-allow-modifications-…
a92e719 
…of-individual-transactions' into 2189-refactor-transaction-flows-to-allow-modifications-of-individual-transactions-fork
@naydenovn
fix: PR changes and additional integration test
1d63b0c 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
fix: adjust existing example
1c0a336 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
Merge branch 'main' into 1219-Streamline-key-and-alias-specifications…
231df0d 
…-for-AccountCreateTransaction

# Conflicts:
#	examples/src/main/java/com/hedera/hashgraph/sdk/examples/AccountCreateWithAndWithoutAliasExample.java
#	examples/src/main/java/com/hedera/hashgraph/sdk/examples/CreateAccountWithAliasExample.java
#	sdk/src/test/java/org/hiero/sdk/AccountCreateTransactionTest.snap
#	sdk/src/testIntegration/java/com/hedera/hashgraph/sdk/test/integration/AccountCreateIntegrationTest.java
@naydenovn
Merge remote-tracking branch 'origin/main'
3836609 
# Conflicts:
#	sdk/src/testIntegration/java/com/hedera/hashgraph/sdk/test/integration/TokenRejectFlowIntegrationTest.java
@naydenovn
Merge branch '1219-Streamline-key-and-alias-specifications-for-Accoun…
8f6a33d 
…tCreateTransaction'
@naydenovn
fix: adjust existing example
3a257fa 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
Merge branch 'hiero-ledger:main' into main
23fd60d
@naydenovn
fix: adjust missing dependency
49edea5 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
fix: adjust PR to contain only alias implementation
0419422 
Signed-off-by: Naydenov <[email protected]>
@naydenovn naydenovn requested a review from a team as a code owner February 3, 2025 12:28
@naydenovn
fix: add missing snap
f560840 
Signed-off-by: Naydenov <[email protected]>
@0xivanov 0xivanov changed the title 2189 refactor transaction flows to allow modifications of individual transactions fork feat: Streamline key and alias specifications for AccountCreateTransaction Feb 3, 2025
0xivanov
0xivanov reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace all calls to setKey with setKeyWithoutAlias?

0xivanov
0xivanov reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is empty file sdk/src/test/java/org/hiero/sdk/AccountCreateTransactionTest.snap - should be removed

@naydenovn
fix: adjust steps
9905dc4 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
Merge remote-tracking branch 'fork/2189-refactor-transaction-flows-to…
26f9d6f 
…-allow-modifications-of-individual-transactions-fork' into 2189-refactor-transaction-flows-to-allow-modifications-of-individual-transactions-fork
@naydenovn
fix: PR comment
a6bc541 
Signed-off-by: Naydenov <[email protected]>
0xivanov
0xivanov approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit 8063dcc into hiero-ledger:main Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xivanov 0xivanov 0xivanov approved these changes

Assignees

@naydenovn naydenovn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Streamline key and alias specifications for AccountCreateTransaction
2 participants
@naydenovn @0xivanov