Update Dependencies #225
Closed
Update Dependencies #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsh006
commented
Oct 15, 2023
•
utkarsh006
commented
- Fixes Issue Upgrade gradle version to latest #18
- App build is successful.
|
@hieuwu Kindly Review. |
hieuwu
previously approved these changes
Oct 15, 2023
| API_KEY=YOUR_SUPABASE_KEY | ||
| SECRET=YOUR_SUPABASE_SECRET | ||
| SUPABASE_URL=YOUR_SUPABASE_URL | ||
| sdk.dir=/Users/hieuvu/Library/Android/sdk | ||
| sdk.dir=C\:\\Users\\HP\\AppData\\Local\\Android\\Sdk |
There was a problem hiding this comment.
@hieuwu This change is auto generated
| gradleVersion = '7.5' | ||
| } | ||
|
|
||
| detekt { | ||
| config = files("${project.rootDir.absolutePath}/config/detekt/detekt.yml") | ||
| buildUponDefaultConfig = true | ||
| } | ||
|
|
||
| ktlint { |
app/build.gradle
Outdated
| @@ -118,13 +117,13 @@ dependencies { | |||
| implementation("androidx.hilt:hilt-navigation-compose:1.0.0") | |||
| implementation "com.github.bumptech.glide:compose:1.0.0-alpha.1" | |||
| implementation "androidx.compose.material3:material3:1.1.1" | |||
| testImplementation("org.mockito:mockito-core:2.1.0") | |||
| testImplementation("org.mockito:mockito-core:5.3.1") | |||
There was a problem hiding this comment.
Please revert changes related to Supabase.
app/build.gradle
Outdated
| sourceCompatibility JavaVersion.VERSION_11 | ||
| targetCompatibility JavaVersion.VERSION_11 | ||
| sourceCompatibility JavaVersion.VERSION_1_8 | ||
| targetCompatibility JavaVersion.VERSION_1_8 |
There was a problem hiding this comment.
Please revert this to as current java version is 12 but new one is java 8.
|
@hieuwu Review now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.