Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittest/usecases #234

Merged
merged 7 commits into from
Dec 27, 2023
Merged

Unittest/usecases #234

merged 7 commits into from
Dec 27, 2023

Conversation

ishanvaghani
Copy link
Contributor

No description provided.

@ishanvaghani
Copy link
Contributor Author

@hieuwu can you please check and merge?

Copy link

sonarcloud bot commented Dec 27, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Owner

@hieuwu hieuwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Could you please share a screenshot of the test result?

lineItemModel.quantity!!,
lineItemModel.id!!
)
if (lineItemModel.quantity != null && lineItemModel.id != null) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one 馃憤

@ishan-vaghani
Copy link

Screenshot 2023-12-27 at 10 37 56鈥疉M

@hieuwu
Copy link
Owner

hieuwu commented Dec 27, 2023

Screenshot 2023-12-27 at 10 37 56鈥疉M

Great work. Thank you for your contribution.

@hieuwu hieuwu merged commit 1c03f41 into hieuwu:main Dec 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants