bugfix/547-image-in-svg-fail #550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2024
PaulDalek
reviewed
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #547, add XLink namespace for SVG results.
Internal note
As described in #547, the SVG is not being rendered properly when there is an
<image xlink:href="base64-image-url"...in the SVG.Here's the cause:
For this reason, the downloaded SVG is incorrect (and the preview in the Export Server's UI does not work as well).
<svg>tag in an HTML document will work without thexmlns:xlinkattribute. However, it will not work as a standalone SVG (or forimage/svg+xmlfile).xmlns:xlinkattribute defined. This is however needed in the exporting solution.The solution in this pull request addresses this issue by adding the proper
xmlns:xlinkattribute to the SVG right before downloading or previewing it. The perfect solution would most likely be to include this attribute on the Highcharts side, not here - but we can consider this later.