fix/error-handling-status #577
Open
+56
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jszuminski Looks good! Setting right status code for each of the |
cvasseng
requested changes
Sep 20, 2024
| @@ -72,7 +72,7 @@ const createImage = (page, type, encoding, clip, rasterizationTimeout) => | |||
| }), | |||
| new Promise((_resolve, reject) => | |||
| setTimeout( | |||
| () => reject(new ExportError('Rasterization timeout')), | |||
| () => reject(new ExportError('Rasterization timeout', 500)), | |||
There was a problem hiding this comment.
I don't know if this should return 500 - I think it should return a 408. It mostly happens when people are trying to export very large charts, so it shouldn't necessarily report back to the health checkers as "there's a problem with the service itself", as the server should be able to recover from it. 500's should be reserved for when the server is in an unrecoverable error state.
A 408 is regardless more applicable when dealing with timeouts in general.
Same for the one on L109.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to throw an appropriate status, depending on whether the issue was caused by the user or by us (the server).
@PaulDalek you were working on the
ExportError.jsso you may know best which parts of code should be worth replacing or if you would like thisstatusCodepassing to look a different way so feel free to push any commits if you'd like it to be solved another way.