add vschema ddl syntax to add/remove tables from unsharded keyspaces

Since unsharded keyspaces don't have vindex definitions, implement a new syntax for adding / removing tables from the vschema: `alter vschema add table test_table` `alter vschema drop table test_table` Signed-off-by: Michael Demmer <[email protected]>
hihihuhu · Dec 7, 2018 · b55d155 · b55d155
1 parent ae79ffd
commit b55d155
Show file tree

Hide file tree

Showing 7 changed files with 1,698 additions and 1,545 deletions.
diff --git a/go/vt/sqlparser/ast.go b/go/vt/sqlparser/ast.go
@@ -746,16 +746,18 @@ type DDL struct {
 
 // DDL strings.
 const (
-	CreateStr        = "create"
-	AlterStr         = "alter"
-	DropStr          = "drop"
-	RenameStr        = "rename"
-	TruncateStr      = "truncate"
-	FlushStr         = "flush"
-	CreateVindexStr  = "create vindex"
-	DropVindexStr    = "drop vindex"
-	AddColVindexStr  = "on table add vindex"
-	DropColVindexStr = "on table drop vindex"
+	CreateStr           = "create"
+	AlterStr            = "alter"
+	DropStr             = "drop"
+	RenameStr           = "rename"
+	TruncateStr         = "truncate"
+	FlushStr            = "flush"
+	CreateVindexStr     = "create vindex"
+	DropVindexStr       = "drop vindex"
+	AddVschemaTableStr  = "add vschema table"
+	DropVschemaTableStr = "drop vschema table"
+	AddColVindexStr     = "on table add vindex"
+	DropColVindexStr    = "on table drop vindex"
 
 	// Vindex DDL param to specify the owner of a vindex
 	VindexOwnerStr = "owner"
@@ -795,6 +797,10 @@ func (node *DDL) Format(buf *TrackedBuffer) {
 		buf.Myprintf("alter vschema create vindex %v %v", node.VindexSpec.Name, node.VindexSpec)
 	case DropVindexStr:
 		buf.Myprintf("alter vschema drop vindex %v", node.VindexSpec.Name)
+	case AddVschemaTableStr:
+		buf.Myprintf("alter vschema add table %v", node.Table)
+	case DropVschemaTableStr:
+		buf.Myprintf("alter vschema drop table %v", node.Table)
 	case AddColVindexStr:
 		buf.Myprintf("alter vschema on %v add vindex %v (", node.Table, node.VindexSpec.Name)
 		for i, col := range node.VindexCols {

diff --git a/go/vt/sqlparser/parse_test.go b/go/vt/sqlparser/parse_test.go
@@ -927,7 +927,9 @@ var (
 	}, {
 		input: "alter vschema drop vindex hash_vdx",
 	}, {
-		input: "alter vschema on a add vindex hash (id)",
+		input: "alter vschema add table a",
+	}, {
+		input: "alter vschema drop table a",
 	}, {
 		input: "alter vschema on a add vindex hash (id)",
 	}, {