Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the whole package related to iterators to increase the stability of dynamic shapes #146

Merged
merged 38 commits into from
Nov 4, 2023

Conversation

hikettei
Copy link
Owner

@hikettei hikettei commented Nov 4, 2023

Changes

  • [BugFix] view with step=-1 wasn't working well: (!view tensor (list 2 3 -1))

    • we have added the vm/iterator package dedicated to calculate offsets considered dynamic shapes.
  • [Refactor] Integrated do-compiled-loop and call-with-view

  • [Refactor] view.lisp is integrated to vm/iterator

  • [Enhancement] JITCPUBackend with dynamic shapes

  • Increased the safety of dynamic shapes, especially when combined with multi dimensional offsets

  • [Enhancement] When creating a tensor, broadcastable axes can be inserted directly:

CL-WAFFE2-REPL> (proceed
		 (!add (ax+b `(3 3) 0 0)
		       (ax+b `(~ 3) 1 0)))

{CPUTENSOR[float] :shape (3 3) :id TID855 
  :vec-state [computed]
  ((0.0 1.0 2.0)
   (0.0 1.0 2.0)
   (0.0 1.0 2.0))
  :facet :input
  :belongs-to :memory-pool
  :requires-grad NIL
  :backward <Node: PROCEEDNODE-T (A[~] -> A[~])>}

…alculating maximum length of elements isn't enough
@hikettei hikettei merged commit 65e38ef into master Nov 4, 2023
1 check passed
@hikettei hikettei deleted the develop branch November 5, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant