Skip to content

Commit

Permalink
Refactor to support AWS ECR
Browse files Browse the repository at this point in the history
  • Loading branch information
hisplan committed Jul 6, 2021
1 parent ae7ff9e commit cce1a78
Show file tree
Hide file tree
Showing 6 changed files with 44 additions and 18 deletions.
4 changes: 2 additions & 2 deletions build.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash

source version.sh
source config.sh

docker build -t pigz:${version} .
docker build -t ${image_name}:${version} .
9 changes: 9 additions & 0 deletions config.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
version="2.4"

# docker related
registry="583643567512.dkr.ecr.us-east-1.amazonaws.com"
image_name="pigz"

# set this to 1 if you want to create a repository in AWS ECR
# set this to 0 for Docker Hub
create_ecr_repo=1
24 changes: 16 additions & 8 deletions package-for-cromwell.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#!/bin/bash -e
#!/bin/bash

hub="hisplan"
image_name="cromwell-pigz"
version="2.4"
source config.sh

image_name="cromwell-${image_name}"

echo "Building ${image_name}:${version}..."

Expand All @@ -17,12 +17,20 @@ cat Dockerfile.cromwell
# build it
docker build -t ${image_name}:${version} -f Dockerfile.cromwell .

echo "Packaging ${hub}/${image_name}:${version}..."
echo "Packaging ${registry}/${image_name}:${version}..."

#
# tag it and push it to docker hub
#

docker login
docker tag ${image_name}:${version} ${hub}/${image_name}:${version}
docker push ${hub}/${image_name}:${version}
docker tag ${image_name}:${version} ${registry}/${image_name}:${version}
if [ $create_ecr_repo == 1 ]
then
# only create if not exist
aws ecr describe-repositories --repository-name ${image_name} 2> /dev/null
if [ $? != 0 ]
then
aws ecr create-repository --repository-name ${image_name}
fi
fi
docker push ${registry}/${image_name}:${version}
17 changes: 17 additions & 0 deletions package.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#!/bin/bash

source config.sh

echo "${registry}/${image_name}:${version}"

docker tag ${image_name}:${version} ${registry}/${image_name}:${version}
if [ $create_ecr_repo == 1 ]
then
# only create if not exist
aws ecr describe-repositories --repository-name ${image_name} 2> /dev/null
if [ $? != 0 ]
then
aws ecr create-repository --repository-name ${image_name}
fi
fi
docker push ${registry}/${image_name}:${version}
7 changes: 0 additions & 7 deletions push.sh

This file was deleted.

1 change: 0 additions & 1 deletion version.sh

This file was deleted.

0 comments on commit cce1a78

Please sign in to comment.