Add geolocations to group_health endpoint #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simfeld
commented
Jul 8, 2021
Comment on lines
+69
to
+75
| # geolocations only exist on Group::Abteilung, thus we can't include geolocations in | ||
| # the queries for other group types | ||
| abt = Group.from("((#{abteilung})) " \ | ||
| "AS #{Group.quoted_table_name}") | ||
| .page(params[:page]).per(params[:size] || DEFAULT_PAGE_SIZE) | ||
| .as_json(only: GROUPS_FIELDS)) | ||
| .as_json(only: GROUPS_FIELDS, | ||
| include: { geolocations: { only: GEOLOCATIONS_FIELDS } }) |
There was a problem hiding this comment.
I first tried to include geolocations in the existing abt_and_below query, but this gave me errors in as_json with include: { geolocations: ... } because the geolocations property only exists for Group::Abteilung. If there's a better way to achieve this than concatenation of two queries I'm happy to adapt it.
simfeld
force-pushed
the
feature/group-health-geolocations
branch
from
97686d1
to
3944926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #195