Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/info logging #479

Open
wants to merge 62 commits into
base: develop-2
Choose a base branch
from
Open

Feature/info logging #479

wants to merge 62 commits into from

Conversation

Sarek
Copy link

@Sarek Sarek commented Mar 30, 2021

Motivation
The traffic flow of the current version is hard to debug because there are no logs for e.g. which messages are sent and received.

Changes
Add additional logging

Closes #411

SgtSilvio added 30 commits March 29, 2021 17:17
@SgtSilvio
Removed deprecated methods
feec2a7
@SgtSilvio
RxClient.publish(Flowable) -> (Publisher)
12b5853
@SgtSilvio
Moved default constants from MqttClient -> TransportConfig
e3ecf95
@SgtSilvio
BlockingClient.Mqtt3/5Publishes -> Publishes
eff5897
@SgtSilvio
FlowableWithSingle.observeOnBoth -> observeBothOn
380e37b
@SgtSilvio
Subscription.getQos -> getMaxQos
53bcd17 
SubscriptionBuilderBase.qos -> maxQos
@SgtSilvio
ssl -> tls
a0275db
@SgtSilvio
MqttClientTransportConfig -> MqttTransportConfig
b2ed27f
@SgtSilvio
MqttClientTlsConfig -> MqttTlsConfig
288cc32
@SgtSilvio
MqttClientExecutorConfig -> MqttExecutorConfig
4e62f54
@SgtSilvio
Mqtt5ClientAdvancedConfig -> Mqtt5AdvancedConfig
b8d2e41
@SgtSilvio
MqttClientAutoReconnect -> MqttAutoReconnect
7bf5a06
@SgtSilvio
MqttClientConnectedContext/Listener -> MqttConnectedContext/Listener
2a655b8 
MqttClientDisconnectedContext/Listener -> MqttDisconnectedContext/Listener
MqttClientReconnector -> MqttReconnector
@SgtSilvio
Reduced package depth of messages
94393af 
- api: max 8 -> 7, internal: max 9 -> 8
- flatted connack, puback/rec/rel/comp, suback, unsuback subpackages
@SgtSilvio
Updated jetrains.annotations to 20.1.0
d62bab3 
Replaced DoNotImplement with ApiStatus.NonExtendable annotation
Add ApiStatus.OverrideOnly annotations
@SgtSilvio
Replaced Immutable with Unmodifiable annotation
40b5e3a
@SgtSilvio
Removed empty ClientModule
7746cfd
@SgtSilvio
Added Range annotations
a9bdcaa
@SgtSilvio
AsyncClient.Mqtt3/5SubscribeAndCallbackBuilder -> .SubscribeBuilder
a36cc5d 
AsyncClient.Mqtt3/5SubscribeAndCallbackBuilder.Call -> .SubscribeBuilder.AfterComplete
AsyncClient.Mqtt3/5SubscribeAndCallbackBuilder.Call.Ex -> .SubscribeBuilder.AfterCallback
@SgtSilvio
Mqtt3/5SubscribeBuilder.Publishes.Args -> .Publishes.AfterComplete
962484e
@SgtSilvio
Add Mqtt3SubscribeBuilderBase.Complete
fb951cf
@SgtSilvio
Add Mqtt3UnsubscribeBuilderBase.Complete
4852412
@SgtSilvio
Add Mqtt5SimpleAuthBuilderBase.Complete
97ddc5c
@SgtSilvio
Add MqttTopicBuilderBase.Complete
7969953
@SgtSilvio
Add With postfix to nested builder methods in ClientBuilder and Trans…
0cd435a 
…portConfigBuilder
@SgtSilvio
Add With postfix to nested builder methods in Reconnector and Advance…
9281fbd 
…dConfigBuilder
@SgtSilvio
Add With postfix to nested builder methods in message builders
f86f591
@SgtSilvio
Mqtt5RetainHandling.SEND_IF_SUBSCRIPTION_DOES_NOT_EXIST -> SEND_IF_NE…
5d755c9 
…W_SUBSCRIPTION
@SgtSilvio
Simplified Mqtt5RetainHandling.getCode
cb64c3b
@SgtSilvio
Refactored MqttCommonReasonCode -> MqttReasonCodes
ea150bc
SgtSilvio and others added 17 commits March 29, 2021 17:20
@SgtSilvio
reactor.version -> 3.4.1
246d8ec
@SgtSilvio
rxjava.version -> 3.0.8
001a2c4
@SgtSilvio
Formatting
bf881e7
@SgtSilvio
Updated test dependencies and gradle plugins
074ab31
@SgtSilvio
MqttClientConfig.getClientIdentifier -> getIdentifier
d0dc865
@SgtSilvio
com.hivemq.client -> com.hivemq.client2
44b4dbf 
hivemq-mqtt-client -> hivemq-mqtt-client2
@SgtSilvio
Formatting
04381a4
@SgtSilvio
Update dependencies
31d25e6
@SgtSilvio
MqttWebSocketConfig.serverPath -> path
dcb0c97 
MqttWebSocketConfig.queryString -> query
DEFAULT_MQTT_SUBPROTOCOL -> DEFAULT_SUBPROTOCOL
@Sarek
Added missing ", " to toAttributeString in MqttStatefulSubscribe
80def8f
@Sarek
Added log level trace to InternalLogger
cf13f8b
@Sarek
Added log level debug to InternalLogger
d87d0b7
@Sarek
Added logs for incoming publishes
874e7b6
@Sarek
Added logs for PINGREQ and PINGRESP
04187fd
@Sarek
Added logs for outgoing publishes
68cad61
@Sarek
Added logs for SUBSCRIBE, UNSUBSCRIBE, SUBACK, UNSUBACK
ecb866d
@Sarek
Added logs for CONNECT, DISCONNECT and channel initialization
c7774b6
@Sarek Sarek requested a review from SgtSilvio as a code owner March 30, 2021 08:44
@cla-bot
Copy link

cla-bot bot commented Mar 30, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Sarek on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@SgtSilvio
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Apr 7, 2021

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label Apr 7, 2021
@SgtSilvio
Copy link
Member

@Sarek You need to sign our CLA before we can review your PR. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

And sorry that you need to rebase your branch, develop-2 is not a stable branch.

@Sarek
Copy link
Author

Sarek commented Apr 9, 2021

No worries, I will sign in the next days, just haven't gotten around to it

@SgtSilvio SgtSilvio force-pushed the develop-2 branch 2 times, most recently from 152a195 to 3b70b25 Compare June 1, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtSilvio SgtSilvio Awaiting requested review from SgtSilvio SgtSilvio is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sarek @SgtSilvio