-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[misc] Add a PyTorch version warning for Conv3D. #9715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @tangefly, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances user guidance by incorporating a critical warning about potential Conv3D performance issues with PyTorch 2.9. Additionally, it refines the documentation by updating quickstart examples and configuration references to feature the Llama3-8B-Instruct model, ensuring that users are presented with the most relevant and up-to-date information for model fine-tuning, inference, and deployment. Minor cleanup of outdated model and dataset listings also improves documentation accuracy. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a warning about a performance degradation issue with Conv3D in PyTorch 2.9 in both the English and Chinese README files. It also includes several maintenance changes, such as removing a deprecated model and dataset from the documentation, and updating example commands to use llama3 instead of qwen3. The changes are mostly good, but I've found a small issue in the English README where the PyTorch issue reference can be improved to be a clickable link and a typo can be removed.
README.md
Outdated
| > Models that rely on Conv3D are not recommended to run on PyTorch 2.9, as Conv3D performance may degrade severely in this version. Refer to PyTorch #166122 | ||
| . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and user experience, it would be great to make the PyTorch issue reference a clickable link. Also, there seems to be a stray dot on the next line which can be removed.
| > Models that rely on Conv3D are not recommended to run on PyTorch 2.9, as Conv3D performance may degrade severely in this version. Refer to PyTorch #166122 | |
| . | |
| > Models that rely on Conv3D are not recommended to run on PyTorch 2.9, as Conv3D performance may degrade severely in this version. Refer to [PyTorch #166122](https://github.com/pytorch/pytorch/issues/166122). |
| | [StarCoder 2](https://huggingface.co/bigcode) | 3B/7B/15B | - | | ||
| | [VibeThinker-1.5B](https://huggingface.co/WeiboAI) | 1.5B | qwen3 | | ||
| | [Yi/Yi-1.5 (Code)](https://huggingface.co/01-ai) | 1.5B/6B/9B/34B | yi | | ||
| | [Youtu-LLM](https://huggingface.co/tencent/) | 2B | youtu | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not delete these lines
README.md
Outdated
| ``` | ||
|
|
||
| > [!WARNING] | ||
| > Models that rely on Conv3D are not recommended to run on PyTorch 2.9, as Conv3D performance may degrade severely in this version. Refer to PyTorch #166122 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add it to code, instead of readme file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 下面三行命令分别对 Llama3-8B-Instruct 模型进行 LoRA **微调**、**推理**和**合并**。 | ||
|
|
||
| ```bash | ||
| llamafactory-cli train examples/train_lora/qwen3_lora_sft.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not modify these lines
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable check in load_model to prevent the use of models containing Conv3D layers with PyTorch 2.9.x versions, which are known to have severe performance regressions. The implementation correctly identifies this combination and raises a ValueError with a clear, informative message. This is a solid approach to proactively avoid a known issue. My feedback includes a minor point on code hygiene regarding an unused import.
hiyouga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Add a PyTorch version warning for Conv3D.
fixes #9282
Before submitting