-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[v1] add init plugin #9716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1] add init plugin #9716
Conversation
Summary of ChangesHello @hiyouga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the flexibility of model initialization and modularizes the sampling architecture within the LlamaFactory project. By introducing a new plugin system for model loading, it allows for more control over how models are placed on devices, which is particularly beneficial for handling large models efficiently. Concurrently, the sampling components have been refactored into a more extensible design, paving the way for easier integration of various sampling backends. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an init_plugin to provide more control over model initialization, which is a valuable addition for handling large models and distributed environments. The implementation of the plugin and its integration into the model loading process is well-structured.
My review has identified a critical issue in the new base_sampler.py where the HuggingFaceEngine class is incomplete, which will cause a runtime error. I also found a high-severity bug in cli_sampler.py related to incorrect handling of asynchronous code. Additionally, I've provided a medium-severity suggestion to improve code style by moving a local import.
Overall, the changes are a good step forward, and after addressing these points, the PR should be in great shape.
What does this PR do?
Fixes # (issue)
Before submitting