Skip to content

Conversation

@hiyouga
Copy link
Owner

@hiyouga hiyouga commented Jan 9, 2026

What does this PR do?

Fixes # (issue)

Before submitting

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hiyouga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a substantial cleanup effort by systematically removing obsolete model configurations and their associated chat templates. This streamlines the codebase, ensuring that only actively supported models are referenced. The documentation (both English and Chinese READMEs) has been updated to reflect these changes, providing an accurate overview of available models. Additionally, Python 3.10 support has been deprecated, and a minor type-hinting improvement was applied to the accelerator module.

Highlights

  • Obsolete Model Removal: Significant cleanup by removing outdated model templates and their corresponding configurations across the codebase.
  • Documentation Synchronization: Updated both English and Chinese READMEs to reflect the current list of supported models, removing entries for models no longer maintained.
  • Python Version Support Adjustment: Python 3.10 is no longer explicitly listed as a supported version in pyproject.toml.
  • Type Hint Refinement: A minor but precise type-hinting change was made in the accelerator interface for the all_gather method.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on cleaning up obsolete models from the codebase, which is a valuable maintenance effort. The changes primarily involve removing model definitions from src/llamafactory/data/template.py and src/llamafactory/extras/constants.py, and these removals are largely consistent. However, I've identified some inconsistencies in the documentation (README.md and README_zh.md) where some models are removed from the documentation but still seem to be supported in the code. Additionally, there's a minor discrepancy between the English and Chinese README files. Please see the detailed comments for suggestions on how to address these issues to ensure the documentation accurately reflects the codebase.

@hiyouga hiyouga merged commit af3b6f5 into main Jan 9, 2026
17 checks passed
@hiyouga hiyouga deleted the hiyouga/clean branch January 9, 2026 06:08
@hiyouga hiyouga added the solved This problem has been already solved label Jan 9, 2026
hiyouga added a commit that referenced this pull request Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

solved This problem has been already solved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants