-
Notifications
You must be signed in to change notification settings - Fork 8.1k
[model] clean obsolete models #9736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @hiyouga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a substantial cleanup effort by systematically removing obsolete model configurations and their associated chat templates. This streamlines the codebase, ensuring that only actively supported models are referenced. The documentation (both English and Chinese READMEs) has been updated to reflect these changes, providing an accurate overview of available models. Additionally, Python 3.10 support has been deprecated, and a minor type-hinting improvement was applied to the accelerator module. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request focuses on cleaning up obsolete models from the codebase, which is a valuable maintenance effort. The changes primarily involve removing model definitions from src/llamafactory/data/template.py and src/llamafactory/extras/constants.py, and these removals are largely consistent. However, I've identified some inconsistencies in the documentation (README.md and README_zh.md) where some models are removed from the documentation but still seem to be supported in the code. Additionally, there's a minor discrepancy between the English and Chinese README files. Please see the detailed comments for suggestions on how to address these issues to ensure the documentation accurately reflects the codebase.
What does this PR do?
Fixes # (issue)
Before submitting