Skip to content

Conversation

connorpgpmcelroy
Copy link
Contributor

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-3044

Change description

Remove all javascript:void(0) instances for CSP alignment
Three replacements done:

  • Edited to button
  • Changed href to hashtag and prevented default reload
  • Removed href from anchors with routerlink

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x ] No

Copy link

@olusegz07
Copy link
Contributor

If user is not navigating anywhere, is it better practice to use a < button > for actions, not an < a > tag.

@connorpgpmcelroy
Copy link
Contributor Author

If user is not navigating anywhere, is it better practice to use a < button > for actions, not an < a > tag.

https://tools.hmcts.net/jira/browse/EXUI-3417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants