- 
                Notifications
    You must be signed in to change notification settings 
- Fork 9
CME-775 angular 20 #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
CME-775 angular 20 #2017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major issues, indentation changes are not great but would be significant workload to go through and change them. Only specific change request is to get rid of the unnecessary const ANY = 'Any' that doesn't seem to be being used
        
          
                projects/ccd-case-ui-toolkit/src/lib/components/form/date-input/date-input.component.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...ed/components/palette/query-management/components/query-details/query-details.component.html
          
            Show resolved
            Hide resolved
        
              
          
                ...b/shared/components/palette/query-management/components/query-list/query-list.component.html
          
            Show resolved
            Hide resolved
        
              
          
                ...ui-toolkit/src/lib/shared/components/workbasket-filters/workbasket-filters.component.spec.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...oolkit/src/lib/shared/components/palette/collection/write-collection-field.component.spec.ts
          
            Show resolved
            Hide resolved
        
      fix indentation in multiple component files and test specs
Update package.json and yarn.lock to use ngx-markdown v20 to maintain compatibility with Angular 20 and other dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes addressed, LGTM
        2f62df5
      
    …g paths - Move mock components from declarations to imports in test configurations - Update routing path parameters from ':jurisdiction' to ':id' - Add standalone: false to mock component decorators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
        24eeb26
      
    
        8170040
      
    | 
 | 



Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CME-775
Change description
Upgrade to angular 20
Does this PR introduce a breaking change? (check one with "x")