Skip to content

Conversation

@anthonydummer
Copy link
Contributor

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/CME-775

Change description

Upgrade to angular 20

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major issues, indentation changes are not great but would be significant workload to go through and change them. Only specific change request is to get rid of the unnecessary const ANY = 'Any' that doesn't seem to be being used

fix indentation in multiple component files and test specs
Update package.json and yarn.lock to use ngx-markdown v20 to maintain compatibility with Angular 20 and other dependencies
@rajaram-moj rajaram-moj changed the title C0T-775 angular 20 CME-775 angular 20 Oct 21, 2025
Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes addressed, LGTM

Josh-HMCTS
Josh-HMCTS previously approved these changes Oct 21, 2025
…g paths

- Move mock components from declarations to imports in test configurations
- Update routing path parameters from ':jurisdiction' to ':id'
- Add standalone: false to mock component decorators
rajaram-moj
rajaram-moj previously approved these changes Oct 22, 2025
Copy link

@rajaram-moj rajaram-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiran-yenigala-hmcts kiran-yenigala-hmcts dismissed stale reviews from rajaram-moj and themself via 24eeb26 October 22, 2025 13:37
AntonyLeons
AntonyLeons previously approved these changes Oct 22, 2025
AntonyLeons
AntonyLeons previously approved these changes Oct 23, 2025
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants