DFR-3526: Draft orders - handle interveners and barrister uploads #2078
+368
−233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into DFR-3334-Approves-or-Changesv2
…eviewLater # Conflicts: # src/main/java/uk/gov/hmcts/reform/finrem/caseorchestration/service/judgeapproval/JudgeApprovalResolver.java
…-3334-Approves-or-Changesv2
…-3334-Approves-or-Changesv2
…-3334-Approves-or-Changesv2
…-3335-refuseOrReviewLater
dawudgovuk
previously approved these changes
Jan 13, 2025
...cts/reform/finrem/caseorchestration/service/documentcategory/DraftOrdersCategoriserTest.java
Show resolved
Hide resolved
ptrelease
reviewed
Jan 14, 2025
.../hmcts/reform/finrem/caseorchestration/service/documentcatergory/DraftOrdersCategoriser.java
Show resolved
Hide resolved
ptrelease
approved these changes
Jan 14, 2025
dawudgovuk
approved these changes
Jan 14, 2025
al-hmcts
approved these changes
Jan 14, 2025
hamzahtahirhmcts
approved these changes
Jan 14, 2025
| case APP_BARRISTER -> OrderFiledBy.APPLICANT_BARRISTER; | ||
| case RESP_BARRISTER -> OrderFiledBy.RESPONDENT_BARRISTER; | ||
| case INTVR_SOLICITOR_1 -> OrderFiledBy.INTERVENER_1; | ||
| case INTVR_SOLICITOR_2 -> OrderFiledBy.INTERVENER_2; |
There was a problem hiding this comment.
This method is great. I like how we are using this to determine where these documents will sit and of course who uploaded them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
https://tools.hmcts.net/jira/browse/DFR-3526
Change description
Add new temporary field (orderFiledBy) to hold who filed the draft order so that uploads by interveners and barristers are supported.
Refactor how documents are categorised so that the orderFiledBy value determines where the documents sit in CFV.