Skip to content

Conversation

ZakMar99
Copy link
Contributor

Jira link

https://tools.hmcts.net/jira/browse/DFR-3864

Change description

Testing done

Security Vulnerability Assessment

CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?

  • Yes
  • No

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@hamzahtahirhmcts
Copy link
Contributor

hamzahtahirhmcts commented Sep 12, 2025

10:50:18  CreateCaseMandatoryDataIntegrationTest > testCreateCaseValidateMandatoryData() FAILED
10:50:18      java.lang.AssertionError: JSON path "$.errors"
10:50:18      Expected: a collection with size <2>
10:50:18           but: collection size was <3>
10:50:18          at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
10:50:18          at org.springframework.test.util.JsonPathExpectationsHelper.assertValue(JsonPathExpectationsHelper.java:107)
10:50:18          at org.springframework.test.web.servlet.result.JsonPathResultMatchers.lambda$value$0(JsonPathResultMatchers.java:88)
10:50:18          at org.springframework.test.web.servlet.MockMvc$1.andExpect(MockMvc.java:214)
10:50:18          at uk.gov.hmcts.reform.finrem.caseorchestration.integrationtest.createcase.CreateCaseMandatoryDataIntegrationTest.testCreateCaseValidateMandatoryData(CreateCaseMandatoryDataIntegrationTest.java:86)

1 integration test failing.

return ret;
}

private boolean shouldSkipRespondentSolicitorValidation(ContactDetailsWrapper contactDetailsWrapper,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The errors list is not used. It should be removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I know the log message was in the Applicant version of this code but I question the value of it.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants