-
Notifications
You must be signed in to change notification settings - Fork 2
Add RespondentSolicitorDetailsValidator class #2551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1 integration test failing. |
...ler/solicitorcreatecase/mandatorydatavalidation/RespondentSolicitorDetailsValidatorTest.java
Outdated
Show resolved
Hide resolved
...rem/caseorchestration/integrationtest/createcase/CreateCaseMandatoryDataIntegrationTest.java
Outdated
Show resolved
Hide resolved
return ret; | ||
} | ||
|
||
private boolean shouldSkipRespondentSolicitorValidation(ContactDetailsWrapper contactDetailsWrapper, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The errors list is not used. It should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I know the log message was in the Applicant version of this code but I question the value of it.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Jira link
https://tools.hmcts.net/jira/browse/DFR-3864
Change description
Testing done
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist