Skip to content

CME-220: 5000 page size test #4525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

CME-220: 5000 page size test #4525

wants to merge 13 commits into from

Conversation

AntonyLeons
Copy link
Contributor

@AntonyLeons AntonyLeons commented Jul 2, 2025 •
edited
Loading

Jira link

https://tools.hmcts.net/jira/browse/CME-220

Change description

Testing done

Security Vulnerability Assessment

CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?

  • Yes
  • No

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@AntonyLeons
Refactor user data caching and role assignment logic for improved sta…
360b014 
…te management

lint

Update yarn-audit-known-issues

Refactor user data caching and role assignment logic for improved state management

Update yarn.lock

Update yarn.lock
AntonyLeons
AntonyLeons commented Jul 10, 2025
View reviewed changes
AntonyLeons
AntonyLeons commented Jul 10, 2025
View reviewed changes
@AntonyLeons
attempt test fix
4892771 
Revert "attempt test fix"

This reverts commit 42e4466.

fix test

Revert "fix test"

This reverts commit 4164d75.

CME-220: fix authtoken issues

Revert "CME-220: fix authtoken issues"

This reverts commit 4d6d059.

remove error throwing
connorpgpmcelroy
connorpgpmcelroy previously approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andywilkinshmcts
andywilkinshmcts requested changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@andywilkinshmcts andywilkinshmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some quite picky comments - sorry. Have a look and see if you think you need to action any of them..

@AntonyLeons
fix(caseWorkerUserDataCache): handle missing CASEWORKER_PAGE_SIZE and…
fd96b1f 
… improve pagination logic

Add fallback value when CASEWORKER_PAGE_SIZE is missing or invalid
Improve pagination termination condition to handle edge cases
connorpgpmcelroy
connorpgpmcelroy previously approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andywilkinshmcts andywilkinshmcts andywilkinshmcts requested changes

@kiran-yenigala-hmcts kiran-yenigala-hmcts kiran-yenigala-hmcts left review comments

@connorpgpmcelroy connorpgpmcelroy connorpgpmcelroy left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ns:xui prd:xui rel:xui-webapp-pr-4525
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AntonyLeons @andywilkinshmcts @kiran-yenigala-hmcts @connorpgpmcelroy