VIH-11256 fix translations and trim service names (#2357)

hmcts · Jan 23, 2025 · 11b7054 · 11b7054
1 parent 14c03f5
commit 11b7054
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/VideoWeb/VideoWeb.Common/Caching/ConferenceCacheMapper.cs b/VideoWeb/VideoWeb.Common/Caching/ConferenceCacheMapper.cs
@@ -61,7 +61,7 @@ public static Conference MapConferenceToCacheModel(ConferenceDetailsResponse con
         conference.IsWaitingRoomOpen = conferenceResponse.IsWaitingRoomOpen;
         conference.CaseName = caseInformation.Name;
         conference.CaseNumber = caseInformation.Number;
-        conference.CaseType = hearingDetailsResponse.ServiceName;
+        conference.CaseType = hearingDetailsResponse.ServiceName.Trim();
         conference.ScheduledDateTime = conferenceResponse.ScheduledDateTime;
         conference.ScheduledDuration = conferenceResponse.ScheduledDuration;
         conference.ClosedDateTime = conferenceResponse.ClosedDateTime;

diff --git a/VideoWeb/VideoWeb/ClientApp/src/app/shared/translation-id-converter.ts b/VideoWeb/VideoWeb/ClientApp/src/app/shared/translation-id-converter.ts
@@ -2,5 +2,8 @@ export function convertStringToTranslationId(str): string {
     if (!str) {
         return '';
     }
-    return str.replace(/[,\s’'/]/g, '-').toLowerCase();
+    return str
+        .trim()
+        .replace(/[,\s’'/]/g, '-')
+        .toLowerCase();
 }
diff --git a/VideoWeb/VideoWeb/ClientApp/src/assets/i18n/cy.json b/VideoWeb/VideoWeb/ClientApp/src/assets/i18n/cy.json
@@ -1337,7 +1337,7 @@
     "upper-tribunals-notice-of-reference-finance-services": "Uwch Dribiwnlys - Hysbysiad Geirda Gwasanaethau Cyllid",
     "upper-tribunals-notice-of-reference-energy-market-decisions": "Uwch Dribiwnlys - Hysbysiad Geirda Penderfyniadau'r Farchnad Ynni",
     "upper-tribunals-notice-of-reference-trade-remedies": "Uwch Dribiwnlys - Hysbysiad Geirda Rhwymedïau Masnach",
-    "upper-tribunals-notice-of-appeal-trade-remedies ": "Uwch Dribiwnlys - Hysbysiad o Apêl Rhwymedïau Masnach",
+    "upper-tribunals-notice-of-appeal-trade-remedies": "Uwch Dribiwnlys - Hysbysiad o Apêl Rhwymedïau Masnach",
     "upper-tribunals-notice-of-appeal-financial-sanctions": "Uwch Dribiwnlys - Hysbysiad o Apêl Cosbau Ariannol",
     "upper-tribunals-judicial-review-applications-(tax)": "Uwch Dribiwnlys - Ceisiadau am Adolygiad Barnwrol (Treth)",
     "upper-tribunals-agricultural-land-and-drainage": "Uwch Dribiwnlys - Tir Amaethyddol a Draenio",

diff --git a/VideoWeb/VideoWeb/ClientApp/src/assets/i18n/en.json b/VideoWeb/VideoWeb/ClientApp/src/assets/i18n/en.json
@@ -917,7 +917,7 @@
     "upper-tribunals-notice-of-reference-finance-services": "Upper Tribunals Notice of Reference Finance Services",
     "upper-tribunals-notice-of-reference-energy-market-decisions": "Upper Tribunals Notice of Reference Energy Market Decisions",
     "upper-tribunals-notice-of-reference-trade-remedies": "Upper Tribunals Notice of Reference Trade Remedies",
-    "upper-tribunals-notice-of-appeal-trade-remedies ": "Upper Tribunals Notice of Appeal Trade Remedies",
+    "upper-tribunals-notice-of-appeal-trade-remedies": "Upper Tribunals Notice of Appeal Trade Remedies",
     "upper-tribunals-notice-of-appeal-financial-sanctions": "Upper Tribunals Notice of Appeal Financial Sanctions",
     "upper-tribunals-judicial-review-applications-(tax)": "Upper Tribunals Judicial Review Applications (Tax)",
     "upper-tribunals-agricultural-land-and-drainage": "Upper Tribunals Agricultural Land and Drainage",