Skip to content

Commit

Permalink
fix illegal tabIndex on non-interactive elements
Browse files Browse the repository at this point in the history
  • Loading branch information
Shaed Parkar committed Apr 15, 2024
1 parent ce9ceb6 commit 1796465
Showing 1 changed file with 0 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
colour="grey"
[class]="{ 'dropdown-opaque': showContextMenu }"
(click)="showContextMenu = !showContextMenu"
tabindex="0"
>
<fa-icon icon="ellipsis-h"></fa-icon>
<div class="dropdown-content" [class]="{ show: showContextMenu }">
Expand All @@ -18,7 +17,6 @@
*ngIf="isHost && !isPrivateConsultation"
colour="grey"
(click)="togglePanelStatus('Chat')"
tabindex="0"
(keyup.enter)="togglePanelStatus('Chat')"
(keyup.space)="togglePanelStatus('Chat')"
>
Expand Down Expand Up @@ -242,7 +240,6 @@
data-module="govuk-button"
(click)="leavePrivateConsultation()"
[hidden]="!canLeaveConsultation()"
tabindex="0"
>
<span>
<fa-icon icon="sign-out-alt" flip="horizontal"></fa-icon>
Expand All @@ -260,7 +257,6 @@
[text]="'private-consultation-room-controls.participants-panel' | translate"
colour="grey"
(click)="togglePanelStatus('Participants')"
tabindex="0"
(keyup.enter)="togglePanelStatus('Participants')"
(keyup.space)="togglePanelStatus('Participants')"
>
Expand Down Expand Up @@ -341,7 +337,6 @@
colour="grey"
disableChildTooltip
(click)="togglePanelStatus('Chat')"
tabindex="0"
(keyup.enter)="togglePanelStatus('Chat')"
(keyup.space)="togglePanelStatus('Chat')"
>
Expand All @@ -357,7 +352,6 @@
[text]="'private-consultation-room-controls.share-my-screen' | translate"
colour="grey"
(click)="showEvidenceContextMenu = !showEvidenceContextMenu"
tabindex="0"
(keyup.enter)="showEvidenceContextMenu = !showEvidenceContextMenu"
(keyup.space)="showEvidenceContextMenu = !showEvidenceContextMenu"
>
Expand Down Expand Up @@ -389,7 +383,6 @@
appTooltip
[text]="'private-consultation-room-controls.unsupported-dynamic-evidence' | translate"
colour="red"
tabindex="0"
>
<p class="unsupported-sharing govuk-!-padding-2 govuk-!-margin-bottom-0">
<fa-icon icon="exclamation-circle" aria-hidden="true"></fa-icon>
Expand Down Expand Up @@ -419,7 +412,6 @@
[text]="'private-consultation-room-controls.stop-sharing-my-screen' | translate"
colour="red"
(click)="stopScreenShare()"
tabindex="0"
>
<fa-icon icon="share-square" class="yellow" rotate="180" (keyup.enter)="stopScreenShare()"></fa-icon>
</div>
Expand All @@ -433,7 +425,6 @@
[text]="'private-consultation-room-controls.change-camera-mic' | translate"
colour="grey"
(click)="changeDeviceSelected()"
tabindex="0"
(keyup.enter)="changeDeviceSelected()"
(keyup.space)="changeDeviceSelected()"
>
Expand All @@ -453,7 +444,6 @@
"
colour="grey"
(click)="toggleView()"
tabindex="0"
(keyup.enter)="toggleView()"
(keyup.space)="toggleView()"
>
Expand All @@ -473,7 +463,6 @@
"
colour="grey"
(click)="toggleVideoMute()"
tabindex="0"
(keyup.enter)="toggleVideoMute()"
(keyup.space)="toggleVideoMute()"
>
Expand All @@ -493,7 +482,6 @@
"
colour="grey"
(click)="toggleMute()"
tabindex="0"
(keyup.enter)="toggleMute()"
(keyup.space)="toggleMute()"
>
Expand Down Expand Up @@ -524,7 +512,6 @@
"
colour="grey"
(click)="toggleHandRaised()"
tabindex="0"
(keyup.enter)="toggleHandRaised()"
(keyup.space)="toggleHandRaised()"
>
Expand All @@ -539,7 +526,6 @@
class="icon-button"
appTooltip
colour="grey"
tabindex="0"
[text]="'private-consultation-room-controls.leave-hearing' | translate"
(keypress)="displayConfirmationLeaveHearingDialog()"
(click)="displayConfirmationLeaveHearingDialog()"
Expand Down

0 comments on commit 1796465

Please sign in to comment.