VIH-11037 Fix for 400 error when no hearings (#2269)

hmcts · Oct 15, 2024 · 9f6f884 · 9f6f884
1 parent 7e613f7
commit 9f6f884
Show file tree

Hide file tree

Showing 3 changed files with 54 additions and 2 deletions.
diff --git a/VideoWeb/VideoWeb.UnitTests/Controllers/ConferenceController/GetConferencesForHostTests.cs b/VideoWeb/VideoWeb.UnitTests/Controllers/ConferenceController/GetConferencesForHostTests.cs
@@ -160,4 +160,27 @@ public async Task Should_return_ok_with_list_of_conferences_where_hearings_and_c
             conferencesForUser[i].CaseName.Should().Be($"CaseName{position}");
         }
     }
+
+    [Test]
+    public async Task Should_return_empty_list_when_no_hearings_found()
+    {
+        // Arrange
+        _mocker.Mock<IBookingsApiClient>()
+            .Setup(x => x.GetConfirmedHearingsByUsernameForTodayV2Async(It.IsAny<string>(), It.IsAny<CancellationToken>()))
+            .ReturnsAsync(new List<ConfirmedHearingsTodayResponseV2>());
+        _mocker.Mock<IVideoApiClient>()
+            .Setup(x => x.GetConferencesByHearingRefIdsAsync(It.IsAny<GetConferencesByHearingIdsRequest>(), It.IsAny<CancellationToken>()))
+            .ReturnsAsync(new List<ConferenceCoreResponse>());
+
+        // Act
+        var result = await _controller.GetConferencesForHostAsync(CancellationToken.None);
+
+        // Assert
+        var typedResult = (OkObjectResult)result.Result;
+        typedResult.Should().NotBeNull();
+        _mocker.Mock<IVideoApiClient>()
+            .Verify(x => x.GetConferencesByHearingRefIdsAsync(It.IsAny<GetConferencesByHearingIdsRequest>(), It.IsAny<CancellationToken>()), Times.Never);
+        var conferencesForUser = (List<ConferenceForHostResponse>) typedResult.Value;
+        conferencesForUser.Should().BeEmpty();
+    }
 }
diff --git a/.../VideoWeb.UnitTests/Controllers/ConferenceController/GetConferencesForStaffMemberTests.cs b/.../VideoWeb.UnitTests/Controllers/ConferenceController/GetConferencesForStaffMemberTests.cs
@@ -89,6 +89,30 @@ public async Task Should_return_ok_with_list_of_conferences()
             conferencesForHost[0].Participants.Count.Should().Be(participants.Count);
         }
 
+        [Test]
+        public async Task Should_return_empty_list_when_no_hearings_found()
+        {
+            // Arrange
+            var venueNames = new List<string>{ "Venue1"};
+            _mocker.Mock<IBookingsApiClient>()
+                .Setup(x => x.GetHearingsForTodayByVenueV2Async(It.IsAny<List<string>>(), It.IsAny<CancellationToken>()))
+                .ReturnsAsync(new List<HearingDetailsResponseV2>());
+            _mocker.Mock<IVideoApiClient>()
+                .Setup(x => x.GetConferencesByHearingRefIdsAsync(It.IsAny<GetConferencesByHearingIdsRequest>(), It.IsAny<CancellationToken>()))
+                .ReturnsAsync(new List<ConferenceCoreResponse>());
+
+            // Act
+            var result = await _controller.GetConferencesForStaffMemberAsync(venueNames, CancellationToken.None);
+
+            // Assert
+            var typedResult = (OkObjectResult)result.Result;
+            typedResult.Should().NotBeNull();
+            _mocker.Mock<IVideoApiClient>()
+                .Verify(x => x.GetConferencesByHearingRefIdsAsync(It.IsAny<GetConferencesByHearingIdsRequest>(), It.IsAny<CancellationToken>()), Times.Never);
+            var conferencesForUser = (List<ConferenceForHostResponse>) typedResult.Value;
+            conferencesForUser.Should().BeEmpty();
+        }
+
         private ConferencesController SetupControllerWithClaims(System.Security.Claims.ClaimsPrincipal claimsPrincipal)
         {
             var context = new ControllerContext

diff --git a/VideoWeb/VideoWeb/Controllers/ConferencesController.cs b/VideoWeb/VideoWeb/Controllers/ConferencesController.cs
@@ -14,6 +14,7 @@
 using Swashbuckle.AspNetCore.Annotations;
 using VideoApi.Client;
 using VideoApi.Contract.Requests;
+using VideoApi.Contract.Responses;
 using VideoWeb.Common;
 using VideoWeb.Common.Models;
 using VideoWeb.Contract.Request;
@@ -54,7 +55,9 @@ public async Task<ActionResult<List<ConferenceForHostResponse>>> GetConferencesF
         var hearings =
             await bookingApiClient.GetConfirmedHearingsByUsernameForTodayV2Async(username, cancellationToken);
         var request = new GetConferencesByHearingIdsRequest { HearingRefIds = hearings.Select(x => x.Id).ToArray() };
-        var conferences = await videoApiClient.GetConferencesByHearingRefIdsAsync(request, cancellationToken);
+        ICollection<ConferenceCoreResponse> conferences = new List<ConferenceCoreResponse>();
+        if (hearings.Count > 0)
+            conferences = await videoApiClient.GetConferencesByHearingRefIdsAsync(request, cancellationToken);
 
         if (conferences.Count != hearings.Count)
             logger.LogError(
@@ -88,7 +91,9 @@ public async Task<ActionResult<List<ConferenceForHostResponse>>> GetConferencesF
             await bookingApiClient.GetHearingsForTodayByVenueV2Async(hearingVenueNames, cancellationToken);
         var request = new GetConferencesByHearingIdsRequest
             { HearingRefIds = hearingsForToday.Select(x => x.Id).ToArray() };
-        var conferences = await videoApiClient.GetConferencesByHearingRefIdsAsync(request, cancellationToken);
+        ICollection<ConferenceCoreResponse> conferences = new List<ConferenceCoreResponse>();
+        if (hearingsForToday.Count > 0)
+            conferences = await videoApiClient.GetConferencesByHearingRefIdsAsync(request, cancellationToken);
         var response = hearingsForToday
             .Select(hearing =>
                 BookingForHostResponseMapper.Map(hearing, conferences.First(c => hearing.Id == c.HearingId)))