-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIH-10597 Vodafone integration #2128
Merged
will-craig
merged 20 commits into
master
from
feature/VIH-10597-Load-vodafone-or-kinly-pexRTC-based-on-supplier-feature-flag
Apr 20, 2024
Merged
VIH-10597 Vodafone integration #2128
will-craig
merged 20 commits into
master
from
feature/VIH-10597-Load-vodafone-or-kinly-pexRTC-based-on-supplier-feature-flag
Apr 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file based on feature flag state. Is loaded at time of video-call.service setup client
oliver-scott
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but and using the test bed is great. Just need to invoke the life cycle for each scenario rather than setting the field
VideoWeb/VideoWeb/ClientApp/src/app/services/api/supplier-client.service.spec.ts
Outdated
Show resolved
Hide resolved
VideoWeb/VideoWeb/ClientApp/src/app/services/api/supplier-client.service.spec.ts
Outdated
Show resolved
Hide resolved
…ing the config with the supplier to allow initialising the pexrtc as early as the app.component initialising
…ll as IAC updates for getting vodafone secrets
…exRTC-based-on-supplier-feature-flag
…exRTC-based-on-supplier-feature-flag
oliver-scott
approved these changes
Apr 17, 2024
shaed-parkar
approved these changes
Apr 17, 2024
Quality Gate passedIssues Measures |
will-craig
deleted the
feature/VIH-10597-Load-vodafone-or-kinly-pexRTC-based-on-supplier-feature-flag
branch
April 20, 2024 12:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link (if applicable)
https://tools.hmcts.net/jira/browse/VIH-10572
Change description
Created a service for dynamically loading the supplier pexrtc client file based on feature flag state. Is loaded at time of video-call.service setup client