Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-10597 Vodafone integration #2128

Conversation

will-craig
Copy link
Contributor

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/VIH-10572

Change description

Created a service for dynamically loading the supplier pexrtc client file based on feature flag state. Is loaded at time of video-call.service setup client

…file based on feature flag state. Is loaded at time of video-call.service setup client
@will-craig will-craig requested review from a team as code owners April 15, 2024 17:21
@will-craig will-craig changed the title VIH-10597 VIH-10597 Vodafone integration Apr 15, 2024
@will-craig will-craig requested a review from a team as a code owner April 15, 2024 17:40
Copy link
Contributor

@shaed-parkar shaed-parkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but and using the test bed is great. Just need to invoke the life cycle for each scenario rather than setting the field

Copy link

@will-craig will-craig merged commit 8bfe73c into master Apr 20, 2024
8 checks passed
@will-craig will-craig deleted the feature/VIH-10597-Load-vodafone-or-kinly-pexRTC-based-on-supplier-feature-flag branch April 20, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants